From: Eric Biggers <ebiggers3@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH v3] statx: optimize copy of struct statx to userspace
Date: Sun, 12 Mar 2017 18:00:28 -0700 [thread overview]
Message-ID: <20170313010028.GA29728@zzz> (raw)
In-Reply-To: <17226.1489309913@warthog.procyon.org.uk>
Hi David,
On Sun, Mar 12, 2017 at 09:11:53AM +0000, David Howells wrote:
> Eric Biggers <ebiggers3@gmail.com> wrote:
>
> > +static int cp_statx(const struct kstat *stat, struct statx __user *buffer)
> > ...
> > + struct statx tmp;
>
> This function needs to be "noinline" as tmp is big.
>
> > - return statx_set_result(&stat, buffer);
> > +
> > + return cp_statx(&stat, buffer);
>
> Can you leave it as statx_set_result rather than renaming it to cp_statx?
>
> David
I agree with using 'noinline'.
But I think the name "cp_statx()" is better because it's consistent with the
existing functions in the file:
cp_old_stat()
cp_new_stat()
cp_new_stat64()
- Eric
prev parent reply other threads:[~2017-03-13 1:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-12 6:29 [PATCH v3] statx: optimize copy of struct statx to userspace Eric Biggers
2017-03-12 9:11 ` David Howells
2017-03-13 1:00 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313010028.GA29728@zzz \
--to=ebiggers3@gmail.com \
--cc=dhowells@redhat.com \
--cc=ebiggers@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).