From: Christoph Hellwig <hch@lst.de>
To: Chandan Rajendra <chandan@linux.vnet.ibm.com>
Cc: hch@lst.de, linux-xfs@vger.kernel.org, darrick.wong@oracle.com,
sandeen@sandeen.net, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC PATCH] iomap_dio_rw: Prevent reading file data beyond iomap_dio->i_size
Date: Fri, 7 Apr 2017 09:17:06 +0200 [thread overview]
Message-ID: <20170407071706.GA26602@lst.de> (raw)
In-Reply-To: <1491545509-27152-1-git-send-email-chandan@linux.vnet.ibm.com>
On Fri, Apr 07, 2017 at 11:41:49AM +0530, Chandan Rajendra wrote:
> The above problem can also be recreated on a regular xfs filesystem
> using the command,
>
> $ fsstress -d /mnt -l 1000 -n 1000 -p 1000
Can you add this to xfstests?
> + if ((iov_iter_rw(iter) == READ) && (pos >= dio->i_size))
> + break;
Please kill both sets of inner braces.
Otherwise this looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2017-04-07 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 6:11 [RFC PATCH] iomap_dio_rw: Prevent reading file data beyond iomap_dio->i_size Chandan Rajendra
2017-04-07 7:17 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407071706.GA26602@lst.de \
--to=hch@lst.de \
--cc=chandan@linux.vnet.ibm.com \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).