From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.136]:46138 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752428AbdDKWOI (ORCPT ); Tue, 11 Apr 2017 18:14:08 -0400 Date: Tue, 11 Apr 2017 15:13:59 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH 4/4] f2fs: avoid frequent checkpoint during f2fs_gc Message-ID: <20170411221359.GA4073@jaegeuk.local> References: <20170411001308.12881-1-jaegeuk@kernel.org> <20170411001308.12881-4-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 04/11, Chao Yu wrote: > On 2017/4/11 8:13, Jaegeuk Kim wrote: > > Now we're doing SSR aggressively more than ever before, so once we reach to > > the reserved_segment, f2fs_balance_fs will call f2fs_gc, which triggers > > checkpoint everytime. We actually must avoid that. > > > > Signed-off-by: Jaegeuk Kim > > --- > > fs/f2fs/gc.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > > index e2f9b2b12b74..4a720f3394d9 100644 > > --- a/fs/f2fs/gc.c > > +++ b/fs/f2fs/gc.c > > @@ -966,7 +966,11 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, bool background) > > * threshold, we can make them free by checkpoint. Then, we > > * secure free segments which doesn't need fggc any more. > > */ > > - ret = write_checkpoint(sbi, &cpc); > > + if (prefree_segments(sbi)) { > > + ret = write_checkpoint(sbi, &cpc); > > + if (ret) > > + goto stop; > > + } > > if (ret) > > goto stop; > > We don't need redundant check here? Yup, will remove this. ;) > > Otherwise, this patchset looks good to me, anyway please add: > > Reviewed-by: Chao Yu Thanks, > > Thanks, > > > if (has_not_enough_free_secs(sbi, 0, 0)) > >