From: Matthew Wilcox <willy@infradead.org>
To: Aurelien Aptel <aaptel@suse.com>
Cc: linux-fsdevel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH 1/1] fs/inode.c: spelling in inode_owner_or_capable doc
Date: Fri, 21 Apr 2017 05:21:38 -0700 [thread overview]
Message-ID: <20170421122138.GD27790@bombadil.infradead.org> (raw)
In-Reply-To: <20170421113758.16274-1-aaptel@suse.com>
On Fri, Apr 21, 2017 at 01:37:58PM +0200, Aurelien Aptel wrote:
> *
> - * Return true if current either has CAP_FOWNER in a namespace with the
> + * Return true if current task has either CAP_FOWNER in a namespace with the
> * inode owner uid mapped, or owns the file.
This is wrong. "if the current task has either FOO or owns the file".
It's also unnecessarily complex. Try this:
* Return true if the current task owns the file or has CAP_FOWNER in a
* namespace with the inode owner uid mapped
("either" in this context would imply exclusive-or, which isn't the intended
meaning).
next prev parent reply other threads:[~2017-04-21 12:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 11:37 [PATCH 1/1] fs/inode.c: spelling in inode_owner_or_capable doc Aurelien Aptel
2017-04-21 12:21 ` Matthew Wilcox [this message]
2017-04-21 13:36 ` Aurélien Aptel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170421122138.GD27790@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=aaptel@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).