From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([65.50.211.133]:60564 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1037629AbdDUMVj (ORCPT ); Fri, 21 Apr 2017 08:21:39 -0400 Date: Fri, 21 Apr 2017 05:21:38 -0700 From: Matthew Wilcox To: Aurelien Aptel Cc: linux-fsdevel@vger.kernel.org, trivial@kernel.org Subject: Re: [PATCH 1/1] fs/inode.c: spelling in inode_owner_or_capable doc Message-ID: <20170421122138.GD27790@bombadil.infradead.org> References: <20170421113758.16274-1-aaptel@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170421113758.16274-1-aaptel@suse.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Apr 21, 2017 at 01:37:58PM +0200, Aurelien Aptel wrote: > * > - * Return true if current either has CAP_FOWNER in a namespace with the > + * Return true if current task has either CAP_FOWNER in a namespace with the > * inode owner uid mapped, or owns the file. This is wrong. "if the current task has either FOO or owns the file". It's also unnecessarily complex. Try this: * Return true if the current task owns the file or has CAP_FOWNER in a * namespace with the inode owner uid mapped ("either" in this context would imply exclusive-or, which isn't the intended meaning).