From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Xiong Zhou <xzhou@redhat.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
fstests@vger.kernel.org, jmoyer@redhat.com, eguan@redhat.com,
Christoph Hellwig <hch@lst.de>,
Dan Williams <dan.j.williams@intel.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-nvdimm@lists.01.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 2/2] dax: add regression test for stale mmap reads
Date: Wed, 26 Apr 2017 12:00:21 -0600 [thread overview]
Message-ID: <20170426180021.GB15921@linux.intel.com> (raw)
In-Reply-To: <20170426090907.q5jj3ywsvldsbq7n@XZHOUW.usersys.redhat.com>
On Wed, Apr 26, 2017 at 05:09:07PM +0800, Xiong Zhou wrote:
> On Tue, Apr 25, 2017 at 02:51:06PM -0600, Ross Zwisler wrote:
<>
> > + /*
> > + * Try and use the mmap to read back the data we just wrote with
> > + * pwrite(). If the kernel bug is present the mapping from the 2MiB
> > + * zero page will still be intact, and we'll read back zeros instead.
> > + */
> > + if (strncmp(buffer, data, strlen(buffer))) {
> > + fprintf(stderr, "strncmp mismatch: '%s' vs '%s'\n", buffer,
> > + data);
> munmap
> close(fd);
> > + exit(1);
> > + }
> > +
> munmap
Yep, thanks, fixed in v3.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-04-26 18:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 20:51 [PATCH v2 1/2] xfs: fix incorrect argument count check Ross Zwisler
2017-04-25 20:51 ` [PATCH v2 2/2] dax: add regression test for stale mmap reads Ross Zwisler
2017-04-26 7:47 ` Eryu Guan
2017-04-26 17:50 ` Ross Zwisler
2017-04-26 9:09 ` Xiong Zhou
2017-04-26 18:00 ` Ross Zwisler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170426180021.GB15921@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=xzhou@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).