From: Christoph Hellwig <hch@lst.de>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Christoph Hellwig <hch@lst.de>,
Amir Goldstein <amir73il@gmail.com>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Vivek Goyal <vgoyal@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-xfs <linux-xfs@vger.kernel.org>,
"linux-unionfs@vger.kernel.org" <linux-unionfs@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2] xfs: publish UUID in struct super_block
Date: Tue, 2 May 2017 17:17:17 +0200 [thread overview]
Message-ID: <20170502151717.GB22963@lst.de> (raw)
In-Reply-To: <CAJfpegsZYUHXpzKX+j=-fFzxDPu5jMH=V8MNOOKtRiu5m0Haig@mail.gmail.com>
On Tue, May 02, 2017 at 05:08:26PM +0200, Miklos Szeredi wrote:
> Two separate issues:
>
> a) is s_uuid unique across all currently mounted filesystems on this system
> b) is s_uuid unique for all different filesystems that have been
> mounted at one time on some system
>
> We can check (a) but not (b). But failing (b) could have equally bad
> consequences as failing (a).
While (b) is harmful it's not anywhere near as harmful as (a). And
while we can trivially protect against (a) protecting against the full
scope of (b) (e.g. including reboots) would be very hard.
next prev parent reply other threads:[~2017-05-02 15:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 14:00 [PATCH v2] xfs: publish UUID in struct super_block Amir Goldstein
2017-04-28 15:13 ` Darrick J. Wong
2017-05-02 7:30 ` Christoph Hellwig
2017-05-02 14:13 ` Amir Goldstein
2017-05-02 14:17 ` Christoph Hellwig
2017-05-02 14:27 ` Amir Goldstein
2017-05-02 14:47 ` Christoph Hellwig
2017-05-02 15:08 ` Miklos Szeredi
2017-05-02 15:17 ` Christoph Hellwig [this message]
2017-05-02 17:09 ` Amir Goldstein
2017-05-02 18:25 ` Amir Goldstein
2017-05-02 18:30 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170502151717.GB22963@lst.de \
--to=hch@lst.de \
--cc=amir73il@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=vgoyal@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).