* [PATCH] Make stat/lstat/fstatat pass AT_NO_AUTOMOUNT to vfs_statx()
@ 2017-05-04 22:30 David Howells
2017-05-04 23:53 ` Al Viro
0 siblings, 1 reply; 2+ messages in thread
From: David Howells @ 2017-05-04 22:30 UTC (permalink / raw)
To: torvalds, viro
Cc: autofs, linux-kernel, stable, dhowells, linux-fsdevel, Ian Kent
stat/lstat/fstatat need to pass AT_NO_AUTOMOUNT to vfs_statx() as the
pre-statx code didn't set LOOKUP_AUTOMOUNT, even though fstatat() accepted
the AT_NO_AUTOMOUNT flag.
Fixes: a528d35e8bfc ("statx: Add a system call to make enhanced file info available")
Reported-by: Ian Kent <raven@themaw.net>
Signed-off-by: David Howells <dhowells@redhat.com>
Tested-by: Ian Kent <raven@themaw.net>
cc: stable@vger.kernel.org
---
include/linux/fs.h | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 5d62d2c47939..626a6aed4485 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2926,17 +2926,19 @@ extern int vfs_statx_fd(unsigned int, struct kstat *, u32, unsigned int);
static inline int vfs_stat(const char __user *filename, struct kstat *stat)
{
- return vfs_statx(AT_FDCWD, filename, 0, stat, STATX_BASIC_STATS);
+ return vfs_statx(AT_FDCWD, filename, AT_NO_AUTOMOUNT,
+ stat, STATX_BASIC_STATS);
}
static inline int vfs_lstat(const char __user *name, struct kstat *stat)
{
- return vfs_statx(AT_FDCWD, name, AT_SYMLINK_NOFOLLOW,
+ return vfs_statx(AT_FDCWD, name, AT_SYMLINK_NOFOLLOW | AT_NO_AUTOMOUNT,
stat, STATX_BASIC_STATS);
}
static inline int vfs_fstatat(int dfd, const char __user *filename,
struct kstat *stat, int flags)
{
- return vfs_statx(dfd, filename, flags, stat, STATX_BASIC_STATS);
+ return vfs_statx(dfd, filename, flags | AT_NO_AUTOMOUNT,
+ stat, STATX_BASIC_STATS);
}
static inline int vfs_fstat(int fd, struct kstat *stat)
{
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Make stat/lstat/fstatat pass AT_NO_AUTOMOUNT to vfs_statx()
2017-05-04 22:30 [PATCH] Make stat/lstat/fstatat pass AT_NO_AUTOMOUNT to vfs_statx() David Howells
@ 2017-05-04 23:53 ` Al Viro
0 siblings, 0 replies; 2+ messages in thread
From: Al Viro @ 2017-05-04 23:53 UTC (permalink / raw)
To: David Howells
Cc: torvalds, autofs, linux-kernel, stable, linux-fsdevel, Ian Kent
On Thu, May 04, 2017 at 11:30:16PM +0100, David Howells wrote:
> stat/lstat/fstatat need to pass AT_NO_AUTOMOUNT to vfs_statx() as the
> pre-statx code didn't set LOOKUP_AUTOMOUNT, even though fstatat() accepted
> the AT_NO_AUTOMOUNT flag.
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-04 23:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-04 22:30 [PATCH] Make stat/lstat/fstatat pass AT_NO_AUTOMOUNT to vfs_statx() David Howells
2017-05-04 23:53 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).