From: Al Viro <viro@ZenIV.linux.org.uk>
To: Pushkar Jambhlekar <pushkar.iit@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] FS: Making aproriate return type
Date: Thu, 11 May 2017 05:20:44 +0100 [thread overview]
Message-ID: <20170511042044.GI390@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1494476049-16139-1-git-send-email-pushkar.iit@gmail.com>
On Thu, May 11, 2017 at 09:44:09AM +0530, Pushkar Jambhlekar wrote:
> unsigned_offsets function returns fmode_t but function definition returns int. sparse generate warning.
> Updating proper return type
You do realize that it's a predicate? This is actually one case where
bool would be appropriate...
prev parent reply other threads:[~2017-05-11 4:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 4:14 [PATCH] FS: Making aproriate return type Pushkar Jambhlekar
2017-05-11 4:20 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170511042044.GI390@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pushkar.iit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).