From: Al Viro <viro@ZenIV.linux.org.uk>
To: David Howells <dhowells@redhat.com>
Cc: mszeredi@redhat.com, jlayton@redhat.com,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/14] Add commands to create or update a superblock
Date: Thu, 11 May 2017 08:38:57 +0100 [thread overview]
Message-ID: <20170511073857.GL390@ZenIV.linux.org.uk> (raw)
In-Reply-To: <149443323117.2378.6029610622093309047.stgit@warthog.procyon.org.uk>
On Wed, May 10, 2017 at 05:20:31PM +0100, David Howells wrote:
> @@ -64,8 +70,8 @@ struct sb_config_operations {
> int (*parse_option)(struct sb_config *sc, char *p);
> int (*monolithic_mount_data)(struct sb_config *sc, void *data);
> int (*validate)(struct sb_config *sc);
> - struct dentry *(*mount)(struct sb_config *sc);
> - int (*fill_super)(struct super_block *s, struct sb_config *sc);
> + int (*create_super)(struct sb_config *sc);
Hell, NO.
The primary effect of that thing is *NOT* to create a superblock. It
might be a side effect, and quite often it will happen, but the
real goal here is a mountable tree. Which might or might not reside
on a new superblock. And which might very well involve no object
creation whatsoever.
This name is actively misleading and the same goes for its relatives
(vfs_create_super(), etc.). It's "give me a tree to mount", not
"create something or other".
next prev parent reply other threads:[~2017-05-11 7:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 16:18 [RFC][PATCH 00/14] VFS: Introduce superblock configuration context David Howells
2017-05-10 16:18 ` [PATCH 01/14] Provide a function to create a NUL-terminated string from unterminated data David Howells
2017-05-10 16:18 ` [PATCH 02/14] Clean up whitespace in fs/namespace.c David Howells
2017-05-10 16:18 ` [PATCH 03/14] VFS: Make get_mnt_ns() return the namespace David Howells
2017-05-10 16:19 ` [PATCH 04/14] VFS: Make get_filesystem() return the affected filesystem David Howells
2017-05-10 16:19 ` [PATCH 05/14] VFS: Provide empty name qstr David Howells
2017-05-10 16:19 ` [PATCH 06/14] VFS: Introduce a superblock configuration context David Howells
2017-05-11 7:24 ` Al Viro
2017-05-10 16:19 ` [PATCH 07/14] Implement fsopen() to prepare for a mount David Howells
2017-05-10 21:59 ` Sargun Dhillon
2017-05-11 14:30 ` David Howells
2017-05-11 14:35 ` Jeff Layton
2017-05-10 16:19 ` [PATCH 08/14] Implement fsmount() to effect a pre-configured mount David Howells
2017-05-10 16:19 ` [PATCH 09/14] Sample program for driving fsopen/fsmount David Howells
2017-05-10 16:19 ` [PATCH 10/14] procfs: Move proc_fill_super() to fs/proc/root.c David Howells
2017-05-10 16:19 ` [PATCH 11/14] proc: Add superblock config support to procfs David Howells
2017-05-10 16:20 ` [PATCH 12/14] NFS: Add mount context support David Howells
2017-05-10 16:20 ` [PATCH 13/14] Support legacy filesystems David Howells
2017-05-10 16:20 ` [PATCH 14/14] Add commands to create or update a superblock David Howells
2017-05-11 7:38 ` Al Viro [this message]
2017-05-11 8:11 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170511073857.GL390@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dhowells@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mszeredi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).