From: Christoph Hellwig <hch@lst.de>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>, Boaz Harrosh <boaz@plexistor.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org,
linux-ima-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH] security/ima: use fs method to read integrity data
Date: Thu, 11 May 2017 10:16:59 +0200 [thread overview]
Message-ID: <20170511081659.GA20214@lst.de> (raw)
In-Reply-To: <1494450047.3006.28.camel@linux.vnet.ibm.com>
On Wed, May 10, 2017 at 05:00:47PM -0400, Mimi Zohar wrote:
> Without i_version support the file is measured/appraised once. �With
> i_version support it will be re-measured/appraised. As a file system
> is mounted/remounted, some sort of message should be emitted
> indicating whether i_version is supported.
You can check for (sb->s_flags & MS_I_VERSION) to see if it's supported.
> �That does not imply that
> there is no value in measuring/appraising the file only once.
>
> With this patch, the "opt-in" behavior, is only for measurement, not
> appraisal. �For appraisal, it still enforces file hash/signature
> verification, as it should, based on policy.
>
> Christoph, could we call ->read_iter() in the NULL case as Boaz
> suggested?
No - that way you get deadlocks for every fs that uses i_rwsem in
->read_iter, which is perfectly valid behavior.
We can set ->integrity_read for every file system that's been tested
with IMA, though. Do you have a list of known-good file systems?
next prev parent reply other threads:[~2017-05-11 8:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 6:45 fix IMA deadlock Christoph Hellwig
2017-05-10 6:45 ` [PATCH] security/ima: use fs method to read integrity data Christoph Hellwig
2017-05-10 12:20 ` Boaz Harrosh
2017-05-10 13:24 ` Christoph Hellwig
2017-05-10 15:55 ` Boaz Harrosh
2017-05-10 21:00 ` Mimi Zohar
2017-05-11 8:16 ` Christoph Hellwig [this message]
2017-05-12 21:09 ` Mimi Zohar
2017-05-10 23:59 ` James Morris
2017-06-04 5:47 ` Christoph Hellwig
2017-06-05 0:23 ` James Morris
2017-06-05 1:57 ` Mimi Zohar
2017-05-11 0:34 ` Li Kun
2017-05-11 0:59 ` Al Viro
2017-05-11 4:03 ` Li Kun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170511081659.GA20214@lst.de \
--to=hch@lst.de \
--cc=boaz@plexistor.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ima-devel@lists.sourceforge.net \
--cc=linux-security-module@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).