From: Christoph Hellwig <hch@infradead.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
kernel-team <kernel-team@lge.com>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
hch@infradead.org, viro@zeniv.linux.org.uk, axboe@kernel.dk,
jlayton@redhat.com, tytso@mit.edu
Subject: Re: [PATCH 2/2] zram: do not count duplicated pages as compressed
Date: Sun, 21 May 2017 00:04:27 -0700 [thread overview]
Message-ID: <20170521070427.GB10453@infradead.org> (raw)
In-Reply-To: <20170517083212.GA25750@bbox>
On Wed, May 17, 2017 at 05:32:12PM +0900, Minchan Kim wrote:
> Is block device(esp, zram which is compressed ram block device) okay to
> return garbage when ongoing overwrite IO fails?
>
> O_DIRECT write 4 block "aaa.." -> success
> read 4 block "aaa.." -> success
> O_DIRECT write 4 block "bbb.." -> fail
> read 4 block "000..' -> it is okay?
>
> Hope to get an answer form experts. :)
It's "okay" as it's what existing real block devices do (at least on a
sector boundary). It's not "nice" though, so if you can avoid it,
please do.
next prev parent reply other threads:[~2017-05-21 7:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170516073616.GB767@jagdpanzerIV.localdomain>
2017-05-17 8:32 ` [PATCH 2/2] zram: do not count duplicated pages as compressed Minchan Kim
2017-05-17 9:14 ` Sergey Senozhatsky
2017-05-18 4:53 ` Minchan Kim
2017-05-21 7:04 ` Christoph Hellwig [this message]
2017-05-21 7:15 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170521070427.GB10453@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=iamjoonsoo.kim@lge.com \
--cc=jlayton@redhat.com \
--cc=kernel-team@lge.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).