From: Al Viro <viro@ZenIV.linux.org.uk>
To: Richard Narron <comet.berkeley@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [git pull] first batch of ufs fixes
Date: Sat, 10 Jun 2017 17:07:38 +0100 [thread overview]
Message-ID: <20170610160738.GE6365@ZenIV.linux.org.uk> (raw)
In-Reply-To: <alpine.LNX.2.21.1706100525410.1939@joy.test>
On Sat, Jun 10, 2017 at 06:03:24AM -0700, Richard Narron wrote:
> 2) After creating a new filesystem on FreeBSD, then on Linux copying a
> larger than 2GB file and creating a directory, the fsck back on FreeBSD
> looks ok.
>
> But after going back to Linux and removing the large file and removing the
> directory, the fsck on FreeBSD looks not so good:
What happens is ufs_evict_inode() buggering off without syncing the inode
in case of final removal. Incremental on top of that branch is
diff --git a/fs/ufs/inode.c b/fs/ufs/inode.c
index 34f11cf0900a..da553ffec85b 100644
--- a/fs/ufs/inode.c
+++ b/fs/ufs/inode.c
@@ -848,6 +848,7 @@ void ufs_evict_inode(struct inode * inode)
(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) ||
S_ISLNK(inode->i_mode)))
ufs_truncate_blocks(inode);
+ ufs_update_inode(inode, inode_needs_sync(inode));
}
invalidate_inode_buffers(inode);
Committed and pushed out...
next prev parent reply other threads:[~2017-06-10 16:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 21:38 [git pull] first batch of ufs fixes Al Viro
2017-06-10 13:03 ` Richard Narron
2017-06-10 16:07 ` Al Viro [this message]
2017-06-10 18:08 ` Al Viro
2017-06-10 18:12 ` Linus Torvalds
2017-06-11 19:47 ` Richard Narron
2017-06-11 21:30 ` Al Viro
2017-06-12 6:14 ` Al Viro
2017-06-13 0:54 ` Richard Narron
2017-06-13 1:43 ` Al Viro
2017-06-13 21:56 ` Richard Narron
2017-06-14 7:11 ` Al Viro
2017-06-14 20:33 ` Richard Narron
2017-06-15 8:00 ` Al Viro
2017-06-16 14:29 ` Richard Narron
2017-06-17 2:15 ` Al Viro
2017-06-18 1:09 ` Al Viro
2017-06-18 20:45 ` Richard Narron
2017-06-20 5:17 ` [git pull] " Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170610160738.GE6365@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=comet.berkeley@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).