From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@ZenIV.linux.org.uk>, Jan Kara <jack@suse.cz>,
tytso@mit.edu, axboe@kernel.dk, mawilcox@microsoft.com,
ross.zwisler@linux.intel.com, corbet@lwn.net,
Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
David Sterba <dsterba@suse.com>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH v6 14/20] dax: set errors in mapping when writeback fails
Date: Mon, 12 Jun 2017 05:44:01 -0700 [thread overview]
Message-ID: <20170612124401.GB18360@infradead.org> (raw)
In-Reply-To: <20170612122316.13244-19-jlayton@redhat.com>
On Mon, Jun 12, 2017 at 08:23:10AM -0400, Jeff Layton wrote:
> For now, only do this when the FS_WB_ERRSEQ flag is set. The
> AS_EIO/AS_ENOSPC flags are not currently cleared in the older code when
> writeback initiation fails, only when we discover an error after waiting
> on writeback to complete, so we only want to do this with errseq_t based
> error handling to prevent seeing duplicate errors on fsync.
Please make sure this doens't stay conditional by the end of the series.
We only have three file systems using dax, and a series should be able
to make them agree on a single interface.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-06-12 12:44 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 12:22 [PATCH v6 00/20] fs: enhanced writeback error reporting with errseq_t (pile #1) Jeff Layton
2017-06-12 12:22 ` [PATCH v6 01/20] mm: fix mapping_set_error call in me_pagecache_dirty Jeff Layton
2017-06-12 12:22 ` [PATCH v6 02/20] buffer: use mapping_set_error instead of setting the flag Jeff Layton
2017-06-12 12:22 ` [PATCH v6 03/20] fs: check for writeback errors after syncing out buffers in generic_file_fsync Jeff Layton
2017-06-12 12:22 ` [PATCH v6 04/20] buffer: set errors in mapping at the time that the error occurs Jeff Layton
2017-06-12 12:22 ` [PATCH v6 05/20] mm: don't TestClearPageError in __filemap_fdatawait_range Jeff Layton
2017-06-12 12:22 ` [PATCH v6 06/20] mm: drop "wait" parameter from write_one_page Jeff Layton
2017-06-12 12:22 ` [PATCH v6 07/20] mm: clean up error handling in write_one_page Jeff Layton
2017-06-12 12:23 ` [PATCH v6 08/20] lib: add errseq_t type and infrastructure for handling it Jeff Layton
2017-06-12 12:23 ` [PATCH v6 09/20] fs: new infrastructure for writeback error handling and reporting Jeff Layton
2017-06-12 12:23 ` [PATCH v6 10/13] ext4: add more robust reporting of metadata writeback errors Jeff Layton
2017-06-12 12:23 ` [PATCH v6 10/20] mm: tracepoints for writeback error events Jeff Layton
2017-06-12 12:23 ` [PATCH v6 11/13] Documentation: flesh out the section in vfs.txt on storing and reporting writeback errors Jeff Layton
2017-06-12 12:23 ` [PATCH v6 11/20] mm: set both AS_EIO/AS_ENOSPC and errseq_t in mapping_set_error Jeff Layton
2017-06-12 12:23 ` [PATCH v6 12/20] fs: add a new fstype flag to indicate how writeback errors are tracked Jeff Layton
2017-06-12 12:45 ` Christoph Hellwig
2017-06-13 10:24 ` Jeff Layton
2017-06-14 6:47 ` Christoph Hellwig
2017-06-14 17:24 ` Jeff Layton
2017-06-15 8:22 ` Christoph Hellwig
2017-06-15 10:42 ` Jeff Layton
2017-06-15 14:57 ` Christoph Hellwig
2017-06-15 15:03 ` Jeff Layton
2017-06-12 12:23 ` [PATCH v6 12/13] xfs: minimal conversion to errseq_t writeback error reporting Jeff Layton
2017-06-12 12:23 ` [PATCH v6 13/13] btrfs: minimal conversion to errseq_t writeback error reporting on fsync Jeff Layton
2017-06-12 12:23 ` [PATCH v6 13/20] Documentation: flesh out the section in vfs.txt on storing and reporting writeback errors Jeff Layton
2017-06-12 12:23 ` [PATCH v6 14/20] dax: set errors in mapping when writeback fails Jeff Layton
2017-06-12 12:44 ` Christoph Hellwig [this message]
2017-06-12 12:23 ` [PATCH v6 15/20] fs: have call_fsync call filemap_report_wb_err if FS_WB_ERRSEQ is set Jeff Layton
2017-06-12 12:42 ` Christoph Hellwig
2017-06-12 12:23 ` [PATCH v6 16/20] block: convert to errseq_t based writeback error tracking Jeff Layton
2017-06-12 12:23 ` [PATCH v6 17/20] fs: add f_md_wb_err field to struct file for tracking metadata errors Jeff Layton
2017-06-12 12:23 ` [PATCH v6 18/20] ext4: use errseq_t based error handling for reporting data writeback errors Jeff Layton
2017-06-12 12:23 ` [PATCH v6 19/20] xfs: minimal conversion to errseq_t writeback error reporting Jeff Layton
2017-06-13 4:30 ` Darrick J. Wong
2017-06-13 10:27 ` Jeff Layton
2017-06-12 12:23 ` [PATCH v6 20/20] btrfs: minimal conversion to errseq_t writeback error reporting on fsync Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612124401.GB18360@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=clm@fb.com \
--cc=corbet@lwn.net \
--cc=darrick.wong@oracle.com \
--cc=dsterba@suse.com \
--cc=jack@suse.cz \
--cc=jbacik@fb.com \
--cc=jlayton@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=ross.zwisler@linux.intel.com \
--cc=tytso@mit.edu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).