Re: udf: allow implicit blocksize specification during mount

["Pali Rohár" <pali.rohar@gmail.com>]

[-- Attachment #1: Type: Text/Plain, Size: 1107 bytes --]

Hi! I found that following UDF patch was included into linus tree:
https://patchwork.kernel.org/patch/9524557/

It is really a good improvement to recognize UDF file system which have 
block size different from disk sector size and also different from 2048.

But should not detection on 4K native disks (4096/4096) try to also use 
block size of 512 bytes? Because current loop is from logical sector 
size to 4096.

Most of current hard drivers are 512/4096 (logical/physical), but there 
are available USB based SATA controllers which via USB mass storage mode 
reports logical block size value from physical block size of SATA disk. 
So via such SATA controller computer see 4096/4096 disk and is unable to 
detect UDF file system if was formatted with 512 block size.

Anyway, macro UDF_DEFAULT_BLOCKSIZE is not used in udf source code 
anymore, so it can be deleted. I think its name was incorrect as default 
block size for UDF should be logical block size of disk, not hardcoded 
value 2048 which is logical block size for optical media.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]