From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Pali =?utf-8?q?Roh=C3=A1r?= To: Fabian Frederick , Jan Kara , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: udf: allow implicit blocksize specification during mount Date: Mon, 12 Jun 2017 22:40:14 +0200 MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1663651.eJ3xAMpQSI"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201706122240.14996@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: --nextPart1663651.eJ3xAMpQSI Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi! I found that following UDF patch was included into linus tree: https://patchwork.kernel.org/patch/9524557/ It is really a good improvement to recognize UDF file system which have=20 block size different from disk sector size and also different from 2048. But should not detection on 4K native disks (4096/4096) try to also use=20 block size of 512 bytes? Because current loop is from logical sector=20 size to 4096. Most of current hard drivers are 512/4096 (logical/physical), but there=20 are available USB based SATA controllers which via USB mass storage mode=20 reports logical block size value from physical block size of SATA disk.=20 So via such SATA controller computer see 4096/4096 disk and is unable to=20 detect UDF file system if was formatted with 512 block size. Anyway, macro UDF_DEFAULT_BLOCKSIZE is not used in udf source code=20 anymore, so it can be deleted. I think its name was incorrect as default=20 block size for UDF should be logical block size of disk, not hardcoded=20 value 2048 which is logical block size for optical media. =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart1663651.eJ3xAMpQSI Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlk+/C4ACgkQi/DJPQPkQ1KpWACgnokHvG5aPqI+/OVH6cKi097x dmMAmwZqtRhyZpBb1v4mTwEevp+ZNaAZ =gAgD -----END PGP SIGNATURE----- --nextPart1663651.eJ3xAMpQSI--