From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([65.50.211.133]:36393 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752445AbdFNQBa (ORCPT ); Wed, 14 Jun 2017 12:01:30 -0400 Date: Wed, 14 Jun 2017 09:01:27 -0700 From: Christoph Hellwig To: Jens Axboe Cc: "Martin K. Petersen" , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, adilger@dilger.ca Subject: Re: [PATCHSET v2] Add support for write life time hints Message-ID: <20170614160127.GA30644@infradead.org> References: <1497412919-19400-1-git-send-email-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Jun 14, 2017 at 09:53:05AM -0600, Jens Axboe wrote: > So how about we just call it "write_hint"? It sounds mostly like a > naming issue to me, as you would then map that to some specific stream > in your driver. You're free to do that right now. They are all flags, > it's just packed as a value to not waste too much space. I think what Martin wants (or at least what I'd want him to want) is to define a few REQ_* bits that mirror the RWF bits, use that to transfer the information down the stack, and then only translate it to stream ids in the driver.