From: Christoph Hellwig <hch@infradead.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
adilger@dilger.ca, hch@infradead.org
Subject: Re: [PATCH 05/12] fs: add fcntl() interface for setting/getting write life time hints
Date: Fri, 16 Jun 2017 10:59:19 -0700 [thread overview]
Message-ID: <20170616175918.GA27996@infradead.org> (raw)
In-Reply-To: <yq1efujq3vq.fsf@oracle.com>
On Fri, Jun 16, 2017 at 12:44:09PM -0400, Martin K. Petersen wrote:
> It seems like an overkill to have different fcntls for different
> hints. And since we are expecting more, maybe these should be
> F_{GET,SET}_HINT and then the individual flags can be
> WRITE_LIFETIME_FOOBAR?
That's what I was trying to explain earlier - have
F_{GET,SET}_HINT ake a u16 (or maybe even a u32 or u64 with the
remainder reserved) and then take 3 bits for the write lifetime.
Which btw means we'd have another 3 possible values left if
we encode is as a value instead of as bits.
next prev parent reply other threads:[~2017-06-16 17:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 16:41 [PATCHSET v5] Add support for write life time hints Jens Axboe
2017-06-15 16:41 ` [PATCH 01/12] block: add support for carrying stream information in a bio Jens Axboe
2017-06-16 16:39 ` Martin K. Petersen
2017-06-16 16:42 ` Jens Axboe
2017-06-15 16:42 ` [PATCH 02/12] blk-mq: expose stream write stats through debugfs Jens Axboe
2017-06-16 16:38 ` Martin K. Petersen
2017-06-16 16:41 ` Jens Axboe
2017-06-15 16:42 ` [PATCH 03/12] fs: add support for an inode to carry write hint related data Jens Axboe
2017-06-15 16:42 ` [PATCH 04/12] fs: add support for allowing applications to pass in write life time hints Jens Axboe
2017-06-15 16:42 ` [PATCH 05/12] fs: add fcntl() interface for setting/getting " Jens Axboe
2017-06-16 16:44 ` Martin K. Petersen
2017-06-16 16:55 ` Jens Axboe
2017-06-16 17:59 ` Christoph Hellwig [this message]
2017-06-15 16:42 ` [PATCH 06/12] block: add helpers for setting/checking write hint validity Jens Axboe
2017-06-16 16:47 ` Martin K. Petersen
2017-06-16 16:53 ` Jens Axboe
2017-06-15 16:42 ` [PATCH 07/12] fs: add O_DIRECT support for sending down bio stream information Jens Axboe
2017-06-15 16:42 ` [PATCH 08/12] fs: add support for buffered writeback to pass down write hints Jens Axboe
2017-06-15 16:42 ` [PATCH 09/12] ext4: add support for passing in write hints for buffered writes Jens Axboe
2017-06-15 16:42 ` [PATCH 10/12] xfs: " Jens Axboe
2017-06-15 16:42 ` [PATCH 11/12] btrfs: " Jens Axboe
2017-06-15 16:42 ` [PATCH 12/12] nvme: add support for streams and directives Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170616175918.GA27996@infradead.org \
--to=hch@infradead.org \
--cc=adilger@dilger.ca \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).