From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@lists.01.org, Mike Snitzer <snitzer@redhat.com>,
Toshi Kani <toshi.kani@hpe.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
dm-devel@redhat.com, viro@zeniv.linux.org.uk,
linux-fsdevel@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH v3 02/14] dm: add ->copy_from_iter() dax operation support
Date: Sun, 18 Jun 2017 10:37:02 +0200 [thread overview]
Message-ID: <20170618083702.GB26456@lst.de> (raw)
In-Reply-To: <149703983692.20620.3787021839815275819.stgit@dwillia2-desk3.amr.corp.intel.com>
> +size_t dax_copy_from_iter(struct dax_device *dax_dev, pgoff_t pgoff, void *addr,
> + size_t bytes, struct iov_iter *i)
> +{
> + if (!dax_alive(dax_dev))
> + return 0;
> +
> + if (!dax_dev->ops->copy_from_iter)
> + return copy_from_iter(addr, bytes, i);
> + return dax_dev->ops->copy_from_iter(dax_dev, pgoff, addr, bytes, i);
> +}
> +EXPORT_SYMBOL_GPL(dax_copy_from_iter);
Can you remove the fallbacks after this series so that we have
a clean abstraction?
next prev parent reply other threads:[~2017-06-18 8:37 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 20:23 [PATCH v3 00/14] pmem: stop abusing __copy_user_nocache(), and other reworks Dan Williams
2017-06-09 20:23 ` [PATCH v3 01/14] x86, uaccess: introduce copy_from_iter_flushcache for pmem / cache-bypass operations Dan Williams
2017-06-18 8:28 ` Christoph Hellwig
2017-06-19 2:02 ` Dan Williams
2017-06-09 20:23 ` [PATCH v3 02/14] dm: add ->copy_from_iter() dax operation support Dan Williams
2017-06-15 0:46 ` Kani, Toshimitsu
2017-06-15 1:21 ` Kani, Toshimitsu
2017-06-18 8:37 ` Christoph Hellwig [this message]
2017-06-19 2:04 ` Dan Williams
2017-06-09 20:24 ` [PATCH v3 03/14] filesystem-dax: convert to dax_copy_from_iter() Dan Williams
2017-06-14 10:58 ` Jan Kara
2017-06-09 20:24 ` [PATCH v3 04/14] dax, pmem: introduce an optional 'flush' dax_operation Dan Williams
2017-06-14 10:57 ` Jan Kara
2017-06-09 20:24 ` [PATCH v3 05/14] dm: add ->flush() dax operation support Dan Williams
2017-06-15 1:44 ` Kani, Toshimitsu
2017-06-09 20:24 ` [PATCH v3 06/14] filesystem-dax: convert to dax_flush() Dan Williams
2017-06-14 10:56 ` Jan Kara
2017-06-09 20:24 ` [PATCH v3 07/14] x86, dax: replace clear_pmem() with open coded memset + dax_ops->flush Dan Williams
2017-06-14 10:55 ` Jan Kara
2017-06-09 20:24 ` [PATCH v3 08/14] x86, dax, libnvdimm: move wb_cache_pmem() to libnvdimm Dan Williams
2017-06-12 0:29 ` [PATCH v4 " Dan Williams
2017-06-14 10:54 ` [PATCH v3 " Jan Kara
2017-06-14 16:49 ` Dan Williams
2017-06-15 8:11 ` Jan Kara
2017-06-18 8:40 ` Christoph Hellwig
2017-06-19 2:06 ` Dan Williams
2017-06-09 20:24 ` [PATCH v3 09/14] x86, libnvdimm, pmem: move arch_invalidate_pmem() " Dan Williams
2017-06-14 10:49 ` Jan Kara
2017-06-09 20:24 ` [PATCH v3 10/14] pmem: remove global pmem api Dan Williams
2017-06-14 10:48 ` Jan Kara
2017-06-09 20:24 ` [PATCH v3 11/14] libnvdimm, pmem: fix persistence warning Dan Williams
2017-06-09 20:24 ` [PATCH v3 12/14] libnvdimm, nfit: enable support for volatile ranges Dan Williams
2017-06-09 20:24 ` [PATCH v3 13/14] filesystem-dax: gate calls to dax_flush() on QUEUE_FLAG_WC Dan Williams
2017-06-14 10:46 ` Jan Kara
2017-06-14 16:49 ` Dan Williams
2017-06-14 23:11 ` [PATCH v4 13/14] libnvdimm, pmem: gate cache management on QUEUE_FLAG_WC in pmem_dax_flush() Dan Williams
2017-06-15 8:09 ` Jan Kara
2017-06-18 8:45 ` [PATCH v3 13/14] filesystem-dax: gate calls to dax_flush() on QUEUE_FLAG_WC Christoph Hellwig
2017-06-19 2:07 ` Dan Williams
2017-06-09 20:25 ` [PATCH v3 14/14] libnvdimm, pmem: disable dax flushing when pmem is fronting a volatile region Dan Williams
2017-06-09 23:21 ` Dan Williams
2017-06-10 17:54 ` [PATCH v4 " Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170618083702.GB26456@lst.de \
--to=hch@lst.de \
--cc=dan.j.williams@intel.com \
--cc=dm-devel@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=snitzer@redhat.com \
--cc=toshi.kani@hpe.com \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).