From: Al Viro <viro@ZenIV.linux.org.uk>
To: Sean Fu <fxinrong@gmail.com>
Cc: shli@kernel.org, anton@tuxera.com, jack@suse.cz, axboe@fb.com,
ebiggers@google.com, rpeterso@redhat.com, bmarzins@redhat.com,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
linux-ntfs-dev@lists.sourceforge.net
Subject: Re: [PATCH] fs: buffer: Modify alloc_page_buffers.
Date: Mon, 19 Jun 2017 17:03:16 +0100 [thread overview]
Message-ID: <20170619160315.GD10672@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1497877296-22441-1-git-send-email-fxinrong@gmail.com>
On Mon, Jun 19, 2017 at 09:01:36PM +0800, Sean Fu wrote:
> Make alloc_page_buffers support circular buffer list and initialise
> b_state field.
> Optimize the performance by removing the buffer list traversal to create
> circular buffer list.
> - bh = head = alloc_page_buffers(page, blocksize, 1);
> + bh = head = alloc_page_buffers(page, blocksize, 1, 0, 0);
Frankly, I don't like that change of calling conventions; it's very easy to
mess the order of arguments when using interfaces like that and it's hell
to find when trying to debug the resulting mess.
Do you really get an observable change in performance? What loads are
triggering it?
next prev parent reply other threads:[~2017-06-19 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 13:01 [PATCH] fs: buffer: Modify alloc_page_buffers Sean Fu
2017-06-19 13:21 ` Jan Kara
2017-06-19 16:03 ` Al Viro [this message]
2017-06-21 17:07 ` Sean Fu
2017-06-23 8:26 ` Sean Fu
2017-06-19 18:20 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619160315.GD10672@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=anton@tuxera.com \
--cc=axboe@fb.com \
--cc=bmarzins@redhat.com \
--cc=ebiggers@google.com \
--cc=fxinrong@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=linux-raid@vger.kernel.org \
--cc=rpeterso@redhat.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).