From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:48242 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757AbdFSTqh (ORCPT ); Mon, 19 Jun 2017 15:46:37 -0400 Date: Mon, 19 Jun 2017 20:46:34 +0100 From: Al Viro To: Deepa Dinamani Cc: Thomas Gleixner , Linux Kernel Mailing List , John Stultz , Nicolas Pitre , Arnd Bergmann , y2038 Mailman List , Linux FS-devel Mailing List Subject: Re: [PATCH 0/8] Isolate time_t data types for clock/timer syscalls Message-ID: <20170619194634.GI10672@ZenIV.linux.org.uk> References: <20170619064515.922-1-deepa.kernel@gmail.com> <20170619072534.GB10672@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jun 19, 2017 at 12:31:00PM -0700, Deepa Dinamani wrote: > 3. I was also aiming for user pointers to be not touched by timer > specific code as it can get messy if not handled properly with 2 > compat time_t versions. So have one helper that deals with all copyout and have it used by all of them. IMO all that code should treat userland representation as completely opaque. Just switch nanosleep_copyout() to take timespec64 instead of timespec (for kernel-side object) and that'll do it, wouldn't it? > Do you guys see any benefit in doing it the way patch 4/8 in the > current series does? Well, if you want to keep more restart functions and more boilerplate on compat side...