From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:49867 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501AbdF1OlN (ORCPT ); Wed, 28 Jun 2017 10:41:13 -0400 Date: Wed, 28 Jun 2017 16:41:12 +0200 From: Christoph Hellwig To: Mimi Zohar Cc: Christoph Hellwig , Al Viro , James Morris , linux-fsdevel@vger.kernel.org, linux-ima-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org Subject: Re: [PATCH v2 10/10] ima: use existing read file operation method to calculate file hash Message-ID: <20170628144111.GI2359@lst.de> References: <1498069110-10009-1-git-send-email-zohar@linux.vnet.ibm.com> <1498069110-10009-11-git-send-email-zohar@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498069110-10009-11-git-send-email-zohar@linux.vnet.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: NAK - we'll need an explicit method for the integrity code. And just curious - what filesystem that you care about actually implements ->read instead of ->read_iter? We shouldn't be doing that for real file systems anymore.