From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cavan.codon.org.uk ([93.93.128.6]:40927 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751796AbdGERw1 (ORCPT ); Wed, 5 Jul 2017 13:52:27 -0400 Date: Wed, 5 Jul 2017 18:02:15 +0100 From: Matthew Garrett To: Mimi Zohar Cc: Christoph Hellwig , Al Viro , James Morris , linux-fsdevel@vger.kernel.org, linux-ima-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, linux-ima-user Subject: Re: [PATCH v2 10/10] ima: use existing read file operation method to calculate file hash Message-ID: <20170705170215.GA14148@srcf.ucam.org> References: <1498069110-10009-1-git-send-email-zohar@linux.vnet.ibm.com> <1498069110-10009-11-git-send-email-zohar@linux.vnet.ibm.com> <20170628144111.GI2359@lst.de> <1499266209.3059.91.camel@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1499266209.3059.91.camel@linux.vnet.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Jul 05, 2017 at 10:50:09AM -0400, Mimi Zohar wrote: > [Cc'ing linux-ima-users] > > On Wed, 2017-06-28 at 16:41 +0200, Christoph Hellwig wrote: > > NAK - we'll need an explicit method for the integrity code. > > > > And just curious - what filesystem that you care about actually > > implements ->read instead of ->read_iter? We shouldn't be doing that > > for real file systems anymore. > > Right, pseudo filesystems are using ->read. The existing builtin > measurement policies exclude a number of pseudo filesystems, but not > efivarfs. �Unfortunately, we do not know what type of custom policies > are currently being used. efi variables contain information that may influence userspace behaviour and can also be modified out of band, so I think there's a reasonable argument that they should be measured. -- Matthew Garrett | mjg59@srcf.ucam.org