* [PATCH] f2fs: include seq_file.h for sysfs.c
@ 2017-07-14 1:01 Jaegeuk Kim
2017-07-17 14:25 ` [f2fs-dev] " Chao Yu
0 siblings, 1 reply; 4+ messages in thread
From: Jaegeuk Kim @ 2017-07-14 1:01 UTC (permalink / raw)
To: linux-kernel, linux-fsdevel, linux-f2fs-devel; +Cc: Jaegeuk Kim, Eric Biggers
This patch includes seq_file.h to avoid compile error.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/sysfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
index 9adc202fcd6f..71191d89917d 100644
--- a/fs/f2fs/sysfs.c
+++ b/fs/f2fs/sysfs.c
@@ -11,6 +11,7 @@
*/
#include <linux/proc_fs.h>
#include <linux/f2fs_fs.h>
+#include <linux/seq_file.h>
#include "f2fs.h"
#include "segment.h"
--
2.13.0.rc1.294.g07d810a77f-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: include seq_file.h for sysfs.c
2017-07-14 1:01 [PATCH] f2fs: include seq_file.h for sysfs.c Jaegeuk Kim
@ 2017-07-17 14:25 ` Chao Yu
2017-07-17 16:55 ` Jaegeuk Kim
0 siblings, 1 reply; 4+ messages in thread
From: Chao Yu @ 2017-07-17 14:25 UTC (permalink / raw)
To: Jaegeuk Kim, linux-kernel, linux-fsdevel, linux-f2fs-devel; +Cc: Eric Biggers
Hi Jaegeuk,
On 2017/7/14 9:01, Jaegeuk Kim wrote:
> This patch includes seq_file.h to avoid compile error.
I didn't hit the error, I guess that's because we have included f2fs_fs.h
in sysfs.c, the inclusion relation is like this:
- sysfs.c
- f2fs_fs.h
- pagemap.h
- fs.h
- struct seq_file
Thanks,
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/sysfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> index 9adc202fcd6f..71191d89917d 100644
> --- a/fs/f2fs/sysfs.c
> +++ b/fs/f2fs/sysfs.c
> @@ -11,6 +11,7 @@
> */
> #include <linux/proc_fs.h>
> #include <linux/f2fs_fs.h>
> +#include <linux/seq_file.h>
>
> #include "f2fs.h"
> #include "segment.h"
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: include seq_file.h for sysfs.c
2017-07-17 14:25 ` [f2fs-dev] " Chao Yu
@ 2017-07-17 16:55 ` Jaegeuk Kim
2017-07-18 1:23 ` Chao Yu
0 siblings, 1 reply; 4+ messages in thread
From: Jaegeuk Kim @ 2017-07-17 16:55 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-kernel, linux-fsdevel, linux-f2fs-devel, Eric Biggers
On 07/17, Chao Yu wrote:
> Hi Jaegeuk,
>
> On 2017/7/14 9:01, Jaegeuk Kim wrote:
> > This patch includes seq_file.h to avoid compile error.
>
> I didn't hit the error, I guess that's because we have included f2fs_fs.h
> in sysfs.c, the inclusion relation is like this:
> - sysfs.c
> - f2fs_fs.h
> - pagemap.h
> - fs.h
> - struct seq_file
What about seq ops such as seq_puts?
Thanks,
>
> Thanks,
>
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> > fs/f2fs/sysfs.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> > index 9adc202fcd6f..71191d89917d 100644
> > --- a/fs/f2fs/sysfs.c
> > +++ b/fs/f2fs/sysfs.c
> > @@ -11,6 +11,7 @@
> > */
> > #include <linux/proc_fs.h>
> > #include <linux/f2fs_fs.h>
> > +#include <linux/seq_file.h>
> >
> > #include "f2fs.h"
> > #include "segment.h"
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: include seq_file.h for sysfs.c
2017-07-17 16:55 ` Jaegeuk Kim
@ 2017-07-18 1:23 ` Chao Yu
0 siblings, 0 replies; 4+ messages in thread
From: Chao Yu @ 2017-07-18 1:23 UTC (permalink / raw)
To: Jaegeuk Kim, Chao Yu
Cc: linux-kernel, linux-fsdevel, linux-f2fs-devel, Eric Biggers
On 2017/7/18 0:55, Jaegeuk Kim wrote:
> On 07/17, Chao Yu wrote:
>> Hi Jaegeuk,
>>
>> On 2017/7/14 9:01, Jaegeuk Kim wrote:
>>> This patch includes seq_file.h to avoid compile error.
>>
>> I didn't hit the error, I guess that's because we have included f2fs_fs.h
>> in sysfs.c, the inclusion relation is like this:
>> - sysfs.c
>> - f2fs_fs.h
>> - pagemap.h
>> - fs.h
>> - struct seq_file
>
> What about seq ops such as seq_puts?
- sysfs.c
- segment.h
- linux/backing-dev.h
- linux/writeback.h
#ifdef CONFIG_CGROUP_WRITEBACK
- linux/cgroup.h
- linux/seq_file.h
#endif
So it looks that there is no compiling error in my environment because
of CONFIG_CGROUP_WRITEBACK was defined.
Anyway, please add:
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
>
> Thanks,
>
>>
>> Thanks,
>>
>>>
>>> Signed-off-by: Eric Biggers <ebiggers@google.com>
>>> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
>>> ---
>>> fs/f2fs/sysfs.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
>>> index 9adc202fcd6f..71191d89917d 100644
>>> --- a/fs/f2fs/sysfs.c
>>> +++ b/fs/f2fs/sysfs.c
>>> @@ -11,6 +11,7 @@
>>> */
>>> #include <linux/proc_fs.h>
>>> #include <linux/f2fs_fs.h>
>>> +#include <linux/seq_file.h>
>>>
>>> #include "f2fs.h"
>>> #include "segment.h"
>>>
>
> .
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-18 1:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-14 1:01 [PATCH] f2fs: include seq_file.h for sysfs.c Jaegeuk Kim
2017-07-17 14:25 ` [f2fs-dev] " Chao Yu
2017-07-17 16:55 ` Jaegeuk Kim
2017-07-18 1:23 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).