From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: gregkh@linuxfoundation.org
Cc: wagi@monom.org, yi1.li@linux.intel.com,
takahiro.akashi@linaro.org, bjorn.andersson@linaro.org,
luto@kernel.org, ebiederm@xmission.com,
dmitry.torokhov@gmail.com, arend.vanspriel@broadcom.com,
dwmw2@infradead.org, rjw@rjwysocki.net, atull@kernel.org,
moritz.fischer@ettus.com, pmladek@suse.com,
johannes.berg@intel.com, emmanuel.grumbach@intel.com,
luciano.coelho@intel.com, kvalo@codeaurora.org,
torvalds@linux-foundation.org, keescook@chromium.org,
dhowells@redhat.com, pjones@redhat.com, hdegoede@redhat.com,
alan@linux.intel.com, tytso@mit.edu, dave@stgolabs.net,
mawilcox@microsoft.com, tglx@linutronix.de, peterz@infradead.org,
mfuzzey@parkeon.com, jakub.kicinski@netronome.com,
nbroeking@me.com, jewalt@lgsinnovations.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
"Luis R. Rodriguez" <mcgrof@kernel.org>
Subject: [PATCH 2/4] firwmare: enable a debug print for batched requests
Date: Sat, 15 Jul 2017 14:18:51 -0700 [thread overview]
Message-ID: <20170715211853.17457-3-mcgrof@kernel.org> (raw)
In-Reply-To: <20170715211853.17457-1-mcgrof@kernel.org>
Otherwise there is no easy way this actually happened.
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
drivers/base/firmware_class.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index 6f58a15efa2b..a85dabeb1e20 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -334,6 +334,7 @@ static struct firmware_buf *__fw_lookup_buf(const char *fw_name)
return NULL;
}
+/* Returns 1 for batching firmware requests with the same name */
static int fw_lookup_and_allocate_buf(const char *fw_name,
struct firmware_cache *fwc,
struct firmware_buf **buf, void *dbuf,
@@ -347,6 +348,7 @@ static int fw_lookup_and_allocate_buf(const char *fw_name,
kref_get(&tmp->ref);
spin_unlock(&fwc->lock);
*buf = tmp;
+ pr_debug("batched request - sharing the same struct firmware_buf and lookup for multiple requests\n");
return 1;
}
tmp = __allocate_fw_buf(fw_name, fwc, dbuf, size);
--
2.11.0
next prev parent reply other threads:[~2017-07-15 21:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-15 21:18 [PATCH 0/4] firmware: few more fixes - fix batched requests Luis R. Rodriguez
2017-07-15 21:18 ` [PATCH 1/4] firmware: define pr_fmt Luis R. Rodriguez
2017-07-15 21:18 ` Luis R. Rodriguez [this message]
2017-07-17 14:31 ` [PATCH 2/4] firwmare: enable a debug print for batched requests Greg KH
2017-07-15 21:18 ` [PATCH 3/4] test_firmware: add batched firmware tests Luis R. Rodriguez
2017-07-15 21:18 ` [PATCH 4/4] firmware: fix batched requests: send wake up on failure on direct lookups Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170715211853.17457-3-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=alan@linux.intel.com \
--cc=arend.vanspriel@broadcom.com \
--cc=atull@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dave@stgolabs.net \
--cc=dhowells@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ebiederm@xmission.com \
--cc=emmanuel.grumbach@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jakub.kicinski@netronome.com \
--cc=jewalt@lgsinnovations.com \
--cc=johannes.berg@intel.com \
--cc=keescook@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=luto@kernel.org \
--cc=mawilcox@microsoft.com \
--cc=mfuzzey@parkeon.com \
--cc=moritz.fischer@ettus.com \
--cc=nbroeking@me.com \
--cc=peterz@infradead.org \
--cc=pjones@redhat.com \
--cc=pmladek@suse.com \
--cc=rjw@rjwysocki.net \
--cc=takahiro.akashi@linaro.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=wagi@monom.org \
--cc=yi1.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).