From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Date: Tue, 18 Jul 2017 02:27:03 +0200
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>, wagi@monom.org,
        yi1.li@linux.intel.com, takahiro.akashi@linaro.org,
        luto@kernel.org, ebiederm@xmission.com, dmitry.torokhov@gmail.com,
        arend.vanspriel@broadcom.com, dwmw2@infradead.org,
        rjw@rjwysocki.net, atull@kernel.org, moritz.fischer@ettus.com,
        pmladek@suse.com, johannes.berg@intel.com,
        emmanuel.grumbach@intel.com, luciano.coelho@intel.com,
        kvalo@codeaurora.org, torvalds@linux-foundation.org,
        keescook@chromium.org, dhowells@redhat.com, pjones@redhat.com,
        hdegoede@redhat.com, alan@linux.intel.com, tytso@mit.edu,
        dave@stgolabs.net, mawilcox@microsoft.com, tglx@linutronix.de,
        peterz@infradead.org, mfuzzey@parkeon.com,
        jakub.kicinski@netronome.com, nbroeking@me.com,
        jewalt@lgsinnovations.com, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] firmware: send -EINTR on signal abort on fallback
 mechanism
Message-ID: <20170718002703.GL21846@wotan.suse.de>
References: <20170629205151.5329-1-mcgrof@kernel.org>
 <20170629205151.5329-5-mcgrof@kernel.org>
 <20170717140007.GA12884@kroah.com>
 <20170717160433.GI21846@wotan.suse.de>
 <20170717162037.GA9583@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170717162037.GA9583@kroah.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, Jul 17, 2017 at 06:20:37PM +0200, Greg KH wrote:
> On Mon, Jul 17, 2017 at 06:04:33PM +0200, Luis R. Rodriguez wrote:
> > On Mon, Jul 17, 2017 at 04:00:07PM +0200, Greg KH wrote:
> > > On Thu, Jun 29, 2017 at 01:51:51PM -0700, Luis R. Rodriguez wrote:
> > > > Right now we send -EAGAIN to a syfs write which got interrupted.
> > > > Userspace can't tell what happened though, send -EINTR if we
> > > > were killed due to a signal so userspace can tell things apart.
> > > > 
> > > > This is only applicable to the fallback mechanism.
> > > > 
> > > > Reported-by: Martin Fuzzey <mfuzzey@parkeon.com>
> > > > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> > > > ---
> > > >  drivers/base/firmware_class.c | 9 ++++++---
> > > >  1 file changed, 6 insertions(+), 3 deletions(-)
> > > 
> > > This doesn't need to go into 4.13-final, right? 
> > 
> > Nope.
> > 
> > > Can it wait for 4.14-rc1?
> > 
> > Yes. The bigger issue was the unexpected signals causing interruption.
> > This I consider a secondary and not critical issue so I did not Cc stable.
> 
> Ok, can you then take your two series of patches, and split them up into
> one for 4.13-final and one for 4.14-rc1 so that I know for sure which is
> which?
>
> As it is, I have to guess :(

Sure thing.

  Luis