From: Christoph Hellwig <hch@infradead.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Jaegeuk Kim <jaegeuk@kernel.org>,
sunqiuyang <sunqiuyang@huawei.com>
Subject: Re: [PATCH v8 1/1] f2fs: dax: implement direct access
Date: Wed, 26 Jul 2017 10:20:11 -0700 [thread overview]
Message-ID: <20170726172011.GA30142@infradead.org> (raw)
In-Reply-To: <CAPcyv4iNP0qxL5vToffBivkQWyUquD7HrgNmvYXQW9ejhFrAmA@mail.gmail.com>
On Wed, Jul 26, 2017 at 10:11:08AM -0700, Dan Williams wrote:
> Until HMAT came along we had no data in the kernel how to pick a sane
> default, but we could now very easily make a "if pmem performance <
> dram, disable dax by default" policy in the kernel.
I'd rather do it the other way around - if HMAT is present and
pmem performance >= dram use dax. Else require the explicit -o dax
for now to enable it. If an explicit -o nodax is specified disable
DAX even if HMAT says it is faster.
> The question for this patch is do we want to add yet another
> filesystem that adds "-o dax" or require use of per-inode flags to
> enable dax.
Please stick to the mount option. After spending a lot of time with
DAX and various memory techologies I'm pretty confident that the inode
flag is the wrong thing to do.
next prev parent reply other threads:[~2017-07-26 17:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 12:10 [PATCH v8 1/1] f2fs: dax: implement direct access sunqiuyang
2017-07-22 0:34 ` Jaegeuk Kim
2017-07-24 12:03 ` Sun Qiuyang
2017-07-26 0:15 ` Dan Williams
2017-07-26 2:16 ` Jaegeuk Kim
2017-07-26 6:47 ` sunqiuyang
2017-07-26 7:26 ` Christoph Hellwig
2017-07-26 16:53 ` Dan Williams
2017-07-26 17:01 ` Christoph Hellwig
2017-07-26 17:11 ` Dan Williams
2017-07-26 17:20 ` Christoph Hellwig [this message]
2017-07-26 19:16 ` Dan Williams
2017-07-26 20:11 ` Christoph Hellwig
2017-07-26 20:29 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170726172011.GA30142@infradead.org \
--to=hch@infradead.org \
--cc=dan.j.williams@intel.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=sunqiuyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).