From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-qk0-f195.google.com ([209.85.220.195]:37203 "EHLO
        mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751659AbdG0V34 (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Thu, 27 Jul 2017 17:29:56 -0400
Received: by mail-qk0-f195.google.com with SMTP id x77so4859413qka.4
        for <linux-fsdevel@vger.kernel.org>; Thu, 27 Jul 2017 14:29:56 -0700 (PDT)
Date: Thu, 27 Jul 2017 18:29:50 -0300
From: Ernesto =?utf-8?Q?A=2E_Fern=C3=A1ndez?=
        <ernesto.mnd.fernandez@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, Jan Kara <jack@suse.cz>,
        Andreas Gruenbacher <agruenba@redhat.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Christoph Hellwig <hch@infradead.org>,
        Vyacheslav Dubeyko <slava@dubeyko.com>,
        Ernesto =?utf-8?Q?A=2E_Fern=C3=A1ndez?=
        <ernesto.mnd.fernandez@gmail.com>
Subject: Re: [PATCH 2/2] hfsplus: add mount option to enable ACL support
Message-ID: <20170727212948.GA3048@debian.home>
References: <4d0758dad0ee32bda49113a957a8b5d9ce882e9b.1501124092.git.ernesto.mnd.fernandez@gmail.com>
 <7f2987dd3b8eace03dece289d35011ef65170c11.1501124092.git.ernesto.mnd.fernandez@gmail.com>
 <20170727094147.GE21100@quack2.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20170727094147.GE21100@quack2.suse.cz>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, Jul 27, 2017 at 11:41:47AM +0200, Jan Kara wrote:
> On Thu 27-07-17 00:13:54, Ernesto A. Fernández wrote:
> > The hfsplus module already has the code to support access control
> > lists, but there is no corresponding mount option. Add it and keep it
> > disabled by default.
> 
> Hum, this seems to be a regression caused by Christoph's ACL rework in
> 2013. Since then HFS+ acls didn't work. So much for how much they are
> used... Maybe time to drop the feature when nobody noticed it does not work
> for 4 years?

I'm not sure the lack of use is a problem of ACLs in particular. I quickly
ran into trouble with extended attributes as well, so my guess is that all
of the module gets very limited use. I'll try and send some patches as
soon as I can.