From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Michael Thayer <michael.thayer@oracle.com>,
"Knut St . Osmundsen" <knut.osmundsen@oracle.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Larry Finger <Larry.Finger@lwfinger.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC 1/2] misc: Add vboxguest driver for Virtual Box Guest integration
Date: Sat, 12 Aug 2017 16:22:48 -0700 [thread overview]
Message-ID: <20170812232248.GA20719@kroah.com> (raw)
In-Reply-To: <82e9619b-0e6d-ae10-28c8-87295ae85389@redhat.com>
On Sat, Aug 12, 2017 at 11:56:22PM +0200, Hans de Goede wrote:
> > 'u32' is not an approprioate type for a kernel header, use '__u32'
> > instead.
>
> Huh I thought that u32 was preferred, but I guess that it is not allowed
> in uapi headers due to potential conflicts and it should be __u32 in uapi
> headers ?
The __ version should always be used in structures/variables that cross
the user/kernel boundry as they are guaranteed to be correct that way.
That is a requirement.
Use the "normal" non __ versions for in-kernel only variables.
hope this helps,
greg k-h
next prev parent reply other threads:[~2017-08-12 23:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 13:23 [RFC 0/2] Add Virtual Box vboxguest and vboxsf guest drivers to the mainline kernel Hans de Goede
2017-08-11 13:23 ` [RFC 1/2] misc: Add vboxguest driver for Virtual Box Guest integration Hans de Goede
2017-08-11 21:23 ` Arnd Bergmann
2017-08-12 21:56 ` Hans de Goede
2017-08-12 23:22 ` Greg Kroah-Hartman [this message]
2017-08-14 7:38 ` Hans de Goede
2017-08-14 9:30 ` Arnd Bergmann
2017-08-14 12:15 ` Hans de Goede
2017-08-21 11:43 ` Hans de Goede
2017-08-21 12:04 ` Hans de Goede
2017-08-11 13:23 ` [RFC 2/2] fs: Add VirtualBox guest shared folder (vboxsf) support Hans de Goede
2017-08-11 15:44 ` [RFC 0/2] Add Virtual Box vboxguest and vboxsf guest drivers to the mainline kernel Greg Kroah-Hartman
2017-08-11 16:02 ` Arnd Bergmann
2017-08-11 16:09 ` Hans de Goede
2017-08-11 16:32 ` Arnd Bergmann
2017-08-11 17:43 ` Hans de Goede
2017-08-11 19:34 ` Arnd Bergmann
2017-08-25 11:53 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170812232248.GA20719@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=arnd@arndb.de \
--cc=hdegoede@redhat.com \
--cc=knut.osmundsen@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.thayer@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).