From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
viro@ZenIV.linux.org.uk
Subject: Re: [PATCH 3/3] xfs: evict all inodes involved with log redo item
Date: Tue, 15 Aug 2017 12:16:02 +1000 [thread overview]
Message-ID: <20170815021602.GG21024@dastard> (raw)
In-Reply-To: <150274843988.16269.18072771696022634179.stgit@magnolia>
On Mon, Aug 14, 2017 at 03:07:19PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> When we introduced the bmap redo log items, we set MS_ACTIVE on the
> mountpoint and XFS_IRECOVERY on the inode to prevent unlinked inodes
> from being truncated prematurely during log recovery. This also had the
> effect of putting linked inodes on the lru instead of evicting them.
>
> Unfortunately, we neglected to find all those unreferenced lru inodes
> and evict them after finishing log recovery, which means that we leak
> them if anything goes wrong in the rest of xfs_mountfs, because the lru
> is only cleaned out on unmount.
That's because if we fail xfs_mountfs() we haven't yet set up
sb->s_root so generic_shutdown_super() won't call evict_inodes(),
right? Is there anything else we might miss from the generic
shutdown path that we need to do here?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2017-08-15 2:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 22:07 [PATCH 1/3] xfs: clear MS_ACTIVE after finishing log recovery Darrick J. Wong
2017-08-14 22:07 ` [PATCH 2/3] xfs: don't leak quotacheck dquots when cow recovery Darrick J. Wong
2017-08-14 22:07 ` [PATCH 3/3] xfs: evict all inodes involved with log redo item Darrick J. Wong
2017-08-15 2:16 ` Dave Chinner [this message]
2017-08-15 4:03 ` Darrick J. Wong
2017-08-16 11:57 ` Brian Foster
2017-08-16 11:56 ` [PATCH 1/3] xfs: clear MS_ACTIVE after finishing log recovery Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815021602.GG21024@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).