From: Christoph Hellwig <hch@lst.de>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, axboe@kernel.dk,
martin.petersen@oracle.com, hch@lst.de
Subject: Re: [PATCH] block: reintroduce discard_zeroes_data sysfs file and BLKDISCARDZEROES
Date: Wed, 16 Aug 2017 17:18:03 +0200 [thread overview]
Message-ID: <20170816151803.GB18932@lst.de> (raw)
In-Reply-To: <1502889581-19483-1-git-send-email-lczerner@redhat.com>
The patch is incorrect - just because we support zeroing using
write zero doesn't mean that any discard will zero the data.
This subtle difference was one of the main point for the changes.
next prev parent reply other threads:[~2017-08-16 15:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 13:19 [PATCH] block: reintroduce discard_zeroes_data sysfs file and BLKDISCARDZEROES Lukas Czerner
2017-08-16 15:18 ` Christoph Hellwig [this message]
2017-08-16 15:48 ` Lukas Czerner
2017-08-17 1:49 ` Martin K. Petersen
2017-08-17 7:47 ` Lukas Czerner
2017-08-17 8:17 ` Christoph Hellwig
2017-08-17 8:41 ` Lukas Czerner
2017-08-17 9:52 ` Christoph Hellwig
2017-08-17 13:35 ` Lukas Czerner
2017-08-17 17:47 ` Martin K. Petersen
2017-08-17 19:35 ` Lukas Czerner
2017-08-17 20:39 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170816151803.GB18932@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=lczerner@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox