linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: <linux-fsdevel@vger.kernel.org>
Cc: Wang Shilong <wangshilong1991@gmail.com>, Jan Kara <jack@suse.cz>
Subject: [PATCH 25/27] quota: Inline dquot_[re]claim_reserved_space() into callsite
Date: Wed, 16 Aug 2017 17:41:25 +0200	[thread overview]
Message-ID: <20170816154127.7048-26-jack@suse.cz> (raw)
In-Reply-To: <20170816154127.7048-1-jack@suse.cz>

dquot_claim_reserved_space() and dquot_reclaim_reserved_space() have
only a single callsite. Inline them there.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 fs/quota/dquot.c | 43 ++++++++++++++++++-------------------------
 1 file changed, 18 insertions(+), 25 deletions(-)

diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index 038f70c1ebff..9f4cf78096e4 100644
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -1082,27 +1082,6 @@ static inline void dquot_resv_space(struct dquot *dquot, qsize_t number)
 	dquot->dq_dqb.dqb_rsvspace += number;
 }
 
-/*
- * Claim reserved quota space
- */
-static void dquot_claim_reserved_space(struct dquot *dquot, qsize_t number)
-{
-	if (dquot->dq_dqb.dqb_rsvspace < number) {
-		WARN_ON_ONCE(1);
-		number = dquot->dq_dqb.dqb_rsvspace;
-	}
-	dquot->dq_dqb.dqb_curspace += number;
-	dquot->dq_dqb.dqb_rsvspace -= number;
-}
-
-static void dquot_reclaim_reserved_space(struct dquot *dquot, qsize_t number)
-{
-	if (WARN_ON_ONCE(dquot->dq_dqb.dqb_curspace < number))
-		number = dquot->dq_dqb.dqb_curspace;
-	dquot->dq_dqb.dqb_rsvspace += number;
-	dquot->dq_dqb.dqb_curspace -= number;
-}
-
 static inline
 void dquot_free_reserved_space(struct dquot *dquot, qsize_t number)
 {
@@ -1726,8 +1705,16 @@ int dquot_claim_space_nodirty(struct inode *inode, qsize_t number)
 	spin_lock(&dq_data_lock);
 	/* Claim reserved quotas to allocated quotas */
 	for (cnt = 0; cnt < MAXQUOTAS; cnt++) {
-		if (dquots[cnt])
-			dquot_claim_reserved_space(dquots[cnt], number);
+		if (dquots[cnt]) {
+			struct dquot *dquot = dquots[cnt];
+
+			if (dquot->dq_dqb.dqb_rsvspace < number) {
+				WARN_ON_ONCE(1);
+				number = dquot->dq_dqb.dqb_rsvspace;
+			}
+			dquot->dq_dqb.dqb_curspace += number;
+			dquot->dq_dqb.dqb_rsvspace -= number;
+		}
 	}
 	/* Update inode bytes */
 	spin_lock(&inode->i_lock);
@@ -1762,8 +1749,14 @@ void dquot_reclaim_space_nodirty(struct inode *inode, qsize_t number)
 	spin_lock(&dq_data_lock);
 	/* Claim reserved quotas to allocated quotas */
 	for (cnt = 0; cnt < MAXQUOTAS; cnt++) {
-		if (dquots[cnt])
-			dquot_reclaim_reserved_space(dquots[cnt], number);
+		if (dquots[cnt]) {
+			struct dquot *dquot = dquots[cnt];
+
+			if (WARN_ON_ONCE(dquot->dq_dqb.dqb_curspace < number))
+				number = dquot->dq_dqb.dqb_curspace;
+			dquot->dq_dqb.dqb_rsvspace += number;
+			dquot->dq_dqb.dqb_curspace -= number;
+		}
 	}
 	/* Update inode bytes */
 	spin_lock(&inode->i_lock);
-- 
2.12.3

  parent reply	other threads:[~2017-08-16 15:41 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-16 15:41 [PATCH 0/27 v1] Quota scalability patches Jan Kara
2017-08-16 15:41 ` [PATCH 01/27] quota: Convert dqio_mutex to rwsem Jan Kara
2017-08-16 16:23   ` Andreas Dilger
2017-08-17 16:47     ` Jan Kara
2017-08-16 15:41 ` [PATCH 02/27] quota: Do more fine-grained locking in dquot_acquire() Jan Kara
2017-08-16 16:35   ` Andreas Dilger
2017-08-17 16:58     ` Jan Kara
2017-08-16 15:41 ` [PATCH 03/27] quota: Acquire dqio_sem for reading in dquot_get_next_id() Jan Kara
2017-08-16 16:37   ` Andreas Dilger
2017-08-16 15:41 ` [PATCH 04/27] quota: Acquire dqio_sem for reading in vfs_load_quota_inode() Jan Kara
2017-08-16 16:38   ` Andreas Dilger
2017-08-16 15:41 ` [PATCH 05/27] quota: Protect dquot writeout with dq_lock Jan Kara
2017-08-16 16:44   ` Andreas Dilger
2017-08-16 15:41 ` [PATCH 06/27] quota: Push dqio_sem down to ->read_dqblk() Jan Kara
2017-08-16 16:46   ` Andreas Dilger
2017-08-16 15:41 ` [PATCH 07/27] quota: Remove locking for reading from the old quota format Jan Kara
2017-08-16 16:47   ` Andreas Dilger
2017-08-16 15:41 ` [PATCH 08/27] quota: Push dqio_sem down to ->write_dqblk() Jan Kara
2017-08-16 16:48   ` Andreas Dilger
2017-08-16 15:41 ` [PATCH 09/27] quota: Do not acquire dqio_sem for dquot overwrites in v2 format Jan Kara
2017-08-16 16:49   ` Andreas Dilger
2017-08-16 15:41 ` [PATCH 10/27] quota: Remove locking for writing to the old quota format Jan Kara
2017-08-16 16:50   ` Andreas Dilger
2017-08-16 15:41 ` [PATCH 11/27] quota: Push dqio_sem down to ->release_dqblk() Jan Kara
2017-08-16 16:56   ` Andreas Dilger
2017-08-16 15:41 ` [PATCH 12/27] quota: Push dqio_sem down to ->get_next_id() Jan Kara
2017-08-16 17:08   ` Andreas Dilger
2017-08-17 17:09     ` Jan Kara
2017-08-16 15:41 ` [PATCH 13/27] quota: Push dqio_sem down to ->write_file_info() Jan Kara
2017-08-16 17:33   ` Andreas Dilger
2017-08-17 17:13     ` Jan Kara
2017-08-16 15:41 ` [PATCH 14/27] quota: Push dqio_sem down to ->read_file_info() Jan Kara
2017-08-16 17:57   ` Andreas Dilger
2017-08-16 15:41 ` [PATCH 15/27] quota: Fix error codes in v2_read_file_info() Jan Kara
2017-08-16 18:00   ` Andreas Dilger
2017-08-16 15:41 ` [PATCH 16/27] quota: Fix possible corruption of dqi_flags Jan Kara
2017-08-16 18:14   ` Andreas Dilger
2017-08-16 15:41 ` [PATCH 17/27] quota: Drop return value of mark_all_dquot_dirty() Jan Kara
2017-08-16 15:41 ` [PATCH 18/27] quota: Do not dirty bad dquots Jan Kara
2017-08-16 15:41 ` [PATCH 19/27] quota: Move locking into clear_dquot_dirty() Jan Kara
2017-08-16 18:29   ` Andreas Dilger
2017-08-16 15:41 ` [PATCH 20/27] quota: Remove dq_wait_unused from dquot Jan Kara
2017-08-16 15:41 ` [PATCH 21/27] quota: Allow disabling tracking of dirty dquots in a list Jan Kara
2017-08-16 15:41 ` [PATCH 22/27] ext4: Disable dirty list tracking of dquots when journalling quotas Jan Kara
2017-08-16 15:41 ` [PATCH 23/27] quota: Inline functions into their callsites Jan Kara
2017-08-16 15:41 ` [PATCH 24/27] quota: Inline inode_{incr,decr}_space() into callsites Jan Kara
2017-08-16 15:41 ` Jan Kara [this message]
2017-08-16 19:52   ` [PATCH 25/27] quota: Inline dquot_[re]claim_reserved_space() into callsite Andreas Dilger
2017-08-16 15:41 ` [PATCH 26/27] fs: Provide __inode_get_bytes() Jan Kara
2017-08-16 16:12   ` Andreas Dilger
2017-08-17 20:04     ` Jan Kara
2017-08-16 15:41 ` [PATCH 27/27] quota: Reduce contention on dq_data_lock Jan Kara
2017-08-16 20:17   ` Andreas Dilger
2017-08-17 20:08     ` Jan Kara
  -- strict thread matches above, loose matches on Subject: below --
2017-08-21 11:54 [PATCH 0/27 v2] Quota scalability patches Jan Kara
2017-08-21 11:55 ` [PATCH 25/27] quota: Inline dquot_[re]claim_reserved_space() into callsite Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170816154127.7048-26-jack@suse.cz \
    --to=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=wangshilong1991@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).