From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
fstests@vger.kernel.org, Eryu Guan <eguan@redhat.com>,
linux-ext4@vger.kernel.org, linux-nvdimm@lists.01.org,
linux-fsdevel@vger.kernel.org, Randy Dodgen <rdodgen@gmail.com>,
Theodore Ts'o <tytso@mit.edu>
Subject: Re: [fstests PATCH] generic: add test for executables on read-only DAX mounts
Date: Wed, 30 Aug 2017 22:02:55 -0600 [thread overview]
Message-ID: <20170831040255.GB17095@linux.intel.com> (raw)
In-Reply-To: <20170830145103.GA10163@infradead.org>
On Wed, Aug 30, 2017 at 07:51:03AM -0700, Christoph Hellwig wrote:
> > The above patch fixes an issue with ext4 where executables cannot be run on
> > read-only filesystems mounted with the DAX option.
> >
> > This issue does not appear to be present in ext2 or XFS, as they both pass
> > the test. I've also confirmed outside of the test that they are both
> > indeed able to execute binaries on read-only DAX mounts.
>
> It works for me on XFS. But I don't really understand why, as the fault
> handler doesn't look very different.
>
> Maybe the problem is that in ext4_journal_start_sb will fail on
> a read-only fs?
>
> Even for xfs/ext2 it would seem odd that things like sb_start_pagefault
> just work.
>
> > +LS=$(which ls --skip-alias --skip-functions) 2>/dev/null
> > +if [ $? -ne 0 ]; then
> > + status=$?
> > + echo "Couldn't find 'ls'!?"
> > + exit
> > +fi
>
> These checks all fail for me..
Huh...really? I'll send out v2 in a second, but if that fails for you as well
can you try and give me a hint as to what's going wrong with the test in your
setup?
next prev parent reply other threads:[~2017-08-31 4:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170829213721.GA27686@linux.intel.com>
2017-08-29 22:37 ` [fstests PATCH] generic: add test for executables on read-only DAX mounts Ross Zwisler
2017-08-30 10:59 ` Eryu Guan
2017-08-31 4:01 ` Ross Zwisler
2017-08-31 4:09 ` [fstests v2] " Ross Zwisler
2017-08-30 14:51 ` [fstests PATCH] " Christoph Hellwig
2017-08-31 4:02 ` Ross Zwisler [this message]
2017-08-31 13:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831040255.GB17095@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=rdodgen@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).