From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: xfs <linux-xfs@vger.kernel.org>,
linux-api@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] fsmap: fix documentation of FMR_OF_LAST
Date: Fri, 1 Sep 2017 10:30:29 +1000 [thread overview]
Message-ID: <20170901003029.GX10621@dastard> (raw)
In-Reply-To: <20170831204918.GA7404@magnolia>
On Thu, Aug 31, 2017 at 01:49:18PM -0700, Darrick J. Wong wrote:
> The FMR_OF_LAST flag is set on the last fsmap record being returned for
> the dataset requested, contrary to what the header file says. Fix the
> docs to reflect the behavior of all fsmap implementations.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> include/uapi/linux/fsmap.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/fsmap.h b/include/uapi/linux/fsmap.h
> index 7e8e5f0b..e5213c3 100644
> --- a/include/uapi/linux/fsmap.h
> +++ b/include/uapi/linux/fsmap.h
> @@ -96,7 +96,7 @@ fsmap_advance(
> #define FMR_OF_EXTENT_MAP 0x4 /* segment = extent map */
> #define FMR_OF_SHARED 0x8 /* segment = shared with another file */
> #define FMR_OF_SPECIAL_OWNER 0x10 /* owner is a special value */
> -#define FMR_OF_LAST 0x20 /* segment is the last in the FS */
> +#define FMR_OF_LAST 0x20 /* segment is the last in the dataset */
>
> /* Each FS gets to define its own special owner codes. */
> #define FMR_OWNER(type, code) (((__u64)type << 32) | \
Looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2017-09-01 0:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 20:49 [PATCH] fsmap: fix documentation of FMR_OF_LAST Darrick J. Wong
2017-09-01 0:30 ` Dave Chinner [this message]
2017-09-01 8:09 ` Christoph Hellwig
2017-09-01 15:07 ` Darrick J. Wong
2017-09-03 8:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901003029.GX10621@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).