From: Jan Kara <jack@suse.cz>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Jan Kara <jack@suse.cz>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
kbuild test robot <fengguang.wu@intel.com>,
Christoph Hellwig <hch@lst.de>,
"Darrick J. Wong" <darrick.wong@oracle.com>
Subject: Re: [PATCH] dax: fix FS_DAX=n BLOCK=y compilation
Date: Mon, 4 Sep 2017 18:03:26 +0200 [thread overview]
Message-ID: <20170904160326.GA8119@quack2.suse.cz> (raw)
In-Reply-To: <CAPcyv4jECxVyHcxTx_HqVd6KzM_j69DSzw_sRJt-GYmwWGkWaw@mail.gmail.com>
On Mon 04-09-17 08:55:33, Dan Williams wrote:
> On Mon, Sep 4, 2017 at 3:26 AM, Jan Kara <jack@suse.cz> wrote:
> > On Sun 03-09-17 10:25:55, Dan Williams wrote:
> >> The 0day kbuild robot reports:
> >>
> >> >> drivers//dax/super.c:64:20: error: redefinition of 'fs_dax_get_by_bdev'
> >> struct dax_device *fs_dax_get_by_bdev(struct block_device *bdev)
> >> ^~~~~~~~~~~~~~~~~~
> >> In file included from drivers//dax/super.c:22:0:
> >> include/linux/dax.h:76:34: note: previous definition of 'fs_dax_get_by_bdev' was here
> >> static inline struct dax_device *fs_dax_get_by_bdev(struct block_device *bdev)
> >> ^~~~~~~~~~~~~~~~~~
> >>
> >> Protect the definition of fs_dax_get_by_bdev() in drivers/dax/super.c
> >> with an ifdef.
> >>
> >> Fixes: 78f354735081 ("dax: introduce a fs_dax_get_by_bdev() helper")
> >> Cc: Jan Kara <jack@suse.cz>
> >> Cc: Christoph Hellwig <hch@lst.de>
> >> Cc: Darrick J. Wong <darrick.wong@oracle.com>
> >> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> >> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> >
> > OK, or you could have both !DAX and DAX implementations in
> > include/linux/dax.h as inline together? It would look a bit more logical to
> > me. But I don't care much. So
> >
> > Reviewed-by: Jan Kara <jack@suse.cz>
>
> My motivation for not doing that is to avoid including blkdev.h from dax.h.
OK, makes sense.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2017-09-04 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 17:25 [PATCH] dax: fix FS_DAX=n BLOCK=y compilation Dan Williams
2017-09-04 10:26 ` Jan Kara
2017-09-04 15:55 ` Dan Williams
2017-09-04 16:03 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904160326.GA8119@quack2.suse.cz \
--to=jack@suse.cz \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=fengguang.wu@intel.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).