linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Brian Foster <bfoster@redhat.com>
Cc: Amir Goldstein <amir73il@gmail.com>,
	"Darrick J . Wong" <darrick.wong@oracle.com>,
	Christoph Hellwig <hch@lst.de>,
	linux-xfs <linux-xfs@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Josef Bacik <jbacik@fb.com>,
	"stable [v4.9]" <stable@vger.kernel.org>
Subject: Re: [PATCH v2] xfs: fix incorrect log_flushed on fsync
Date: Tue, 5 Sep 2017 16:54:42 +0200	[thread overview]
Message-ID: <20170905145442.GA6869@lst.de> (raw)
In-Reply-To: <20170905144006.GA48515@bfoster.bfoster>

On Tue, Sep 05, 2017 at 10:40:07AM -0400, Brian Foster wrote:
> Thanks.. I agree that a rework of the optimization can come later now
> that the bug is fixed.

I agree in principle, but I don't think the patch in for-next is enough,
given that it doesn't take ic_refcnt into account.

> Christoph, are you planning to continue with your flushseq based patch?

I think it is fundamentally the right thing to do, but given how
much I've got on my plate I wouldn't mind someone else looking into it :)

  reply	other threads:[~2017-09-05 14:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-01 15:39 [PATCH v2] xfs: fix incorrect log_flushed on fsync Amir Goldstein
2017-09-02 13:19 ` Brian Foster
2017-09-02 15:47   ` Amir Goldstein
2017-09-05 14:40     ` Brian Foster
2017-09-05 14:54       ` Christoph Hellwig [this message]
2017-09-05 15:34         ` Brian Foster
2017-09-06 11:41           ` Christoph Hellwig
2017-09-06 12:08       ` Amir Goldstein
2017-09-06 13:19         ` Christoph Hellwig
2017-09-06 13:29           ` Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170905145442.GA6869@lst.de \
    --to=hch@lst.de \
    --cc=amir73il@gmail.com \
    --cc=bfoster@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=jbacik@fb.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).