From: Christoph Hellwig <hch@lst.de>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Brian Foster <bfoster@redhat.com>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Christoph Hellwig <hch@lst.de>,
linux-xfs <linux-xfs@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Josef Bacik <jbacik@fb.com>,
linux-block <linux-block@vger.kernel.org>
Subject: Re: [PATCH v2] xfs: fix incorrect log_flushed on fsync
Date: Wed, 6 Sep 2017 15:19:37 +0200 [thread overview]
Message-ID: <20170906131937.GA27974@lst.de> (raw)
In-Reply-To: <CAOQ4uxjigcrH0FQVjB0nD-B4wHf5o0qax8+1_3xhi6UAqMRq=w@mail.gmail.com>
> You could also say that flush sequence counting code doesn't belong
> to xfs code at all. There is nothing xfs specific about it.
>
> If we had an API:
>
> flush_seq = blkdev_get_flush_seq(bdev, flush_seq);
> blkdev_issue_flush_after(bdev, flush_seq);
>
> I am sure it would have been useful to more fs.
>
> In fact, block drivers that use blk_insert_flush(),
> already have serialized flush requests, so implementing
> the above functionality would be quite trivial for those.
>
> I am not fluent enough in block layer to say if this makes sense.
> Christoph? Should we add some block people to this discussion?
Not that the interface can't be based on blkdev_issue_flush as
our most important flushes are submitted asynchronously.
But except for that tying into the flush state machine sounds
very interesting. Let me look into that as the designate
xfs <-> block layer liaison.
next prev parent reply other threads:[~2017-09-06 13:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 15:39 [PATCH v2] xfs: fix incorrect log_flushed on fsync Amir Goldstein
2017-09-02 13:19 ` Brian Foster
2017-09-02 15:47 ` Amir Goldstein
2017-09-05 14:40 ` Brian Foster
2017-09-05 14:54 ` Christoph Hellwig
2017-09-05 15:34 ` Brian Foster
2017-09-06 11:41 ` Christoph Hellwig
2017-09-06 12:08 ` Amir Goldstein
2017-09-06 13:19 ` Christoph Hellwig [this message]
2017-09-06 13:29 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906131937.GA27974@lst.de \
--to=hch@lst.de \
--cc=amir73il@gmail.com \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=jbacik@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).