From: Al Viro <viro@ZenIV.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
"linux-unionfs@vger.kernel.org" <linux-unionfs@vger.kernel.org>
Subject: Re: [experimental PATCH] ovl: get rid of d_real()
Date: Fri, 15 Sep 2017 15:07:34 +0100 [thread overview]
Message-ID: <20170915140734.GY5426@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20170915135805.GD19278@veci.piliscsaba.szeredi.hu>
On Fri, Sep 15, 2017 at 03:58:05PM +0200, Miklos Szeredi wrote:
> And here's the prototype. Poof, d_real() is gone.
>
> It definitely has got problems, but just maybe it can be made better than the
> current mess. It *does* solve the ro-rw inconsistency for normal reads (not
> mmaps).
... and makes for mind-boggling amount of opening/closing the files on underlying
filesystem. Doing that on sodding ->read_iter() is simply wrong. And you are
using the wrong credentials for those opens, anyway - it should be creds of opener,
not reader.
next prev parent reply other threads:[~2017-09-15 14:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 13:58 [experimental PATCH] ovl: get rid of d_real() Miklos Szeredi
2017-09-15 14:07 ` Al Viro [this message]
2017-09-15 17:11 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170915140734.GY5426@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).