From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([65.50.211.133]:43818 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753377AbdIRR4w (ORCPT ); Mon, 18 Sep 2017 13:56:52 -0400 Date: Mon, 18 Sep 2017 10:56:51 -0700 From: Christoph Hellwig To: Lukas Czerner Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH 4/7] xfs: Implement fallocate query support mode Message-ID: <20170918175651.GA7937@infradead.org> References: <1505749947-26360-1-git-send-email-lczerner@redhat.com> <1505749947-26360-5-git-send-email-lczerner@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505749947-26360-5-git-send-email-lczerner@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: This seems to miss any explanation and 6 out of 7 patches. That being said, I really detest adding weird query modes to random syscalls. We should expose capabilities through the interface that was designed for such things: (f)pathconf, as there are a lot more important parameters we currently fail to expose to userspace to start with.