linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hirofumi Nakagawa <nklabs@gmail.com>
To: viro@zeniv.linux.org.uk, keescook@chromium.org, anton@enomsg.org,
	ccross@android.com, tony.luck@intel.com,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Hirofumi Nakagawa <nklabs@gmail.com>
Subject: [PATCH 1/2] vfs: remove unneeded unlikely()
Date: Tue, 26 Sep 2017 03:21:26 +0900	[thread overview]
Message-ID: <20170925182127.11160-1-nklabs@gmail.com> (raw)

IS_ERR() macro it is already including unlikely().

Signed-off-by: Hirofumi Nakagawa <nklabs@gmail.com>
---
 fs/namei.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/namei.c b/fs/namei.c
index c75ea03ca147..00384488fda1 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -3458,7 +3458,7 @@ static int do_tmpfile(struct nameidata *nd, unsigned flags,
 		goto out;
 	child = vfs_tmpfile(path.dentry, op->mode, op->open_flag);
 	error = PTR_ERR(child);
-	if (unlikely(IS_ERR(child)))
+	if (IS_ERR(child))
 		goto out2;
 	dput(path.dentry);
 	path.dentry = child;
-- 
2.14.1

             reply	other threads:[~2017-09-25 18:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-25 18:21 Hirofumi Nakagawa [this message]
2017-09-25 18:21 ` [PATCH 2/2] pstore: remove unneeded unlikely() Hirofumi Nakagawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170925182127.11160-1-nklabs@gmail.com \
    --to=nklabs@gmail.com \
    --cc=anton@enomsg.org \
    --cc=ccross@android.com \
    --cc=keescook@chromium.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).