From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 3 Oct 2017 10:38:34 +0200 From: Jan Kara To: Dave Chinner Cc: Jan Kara , Andrew Morton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 10/15] mm: Use pagevec_lookup_range_tag() in __filemap_fdatawait_range() Message-ID: <20171003083834.GF11879@quack2.suse.cz> References: <20170927160334.29513-1-jack@suse.cz> <20170927160334.29513-11-jack@suse.cz> <20170927221902.GG10621@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170927221902.GG10621@dastard> Sender: owner-linux-mm@kvack.org List-ID: On Thu 28-09-17 08:19:02, Dave Chinner wrote: > On Wed, Sep 27, 2017 at 06:03:29PM +0200, Jan Kara wrote: > > Use pagevec_lookup_range_tag() in __filemap_fdatawait_range() as it is > > interested only in pages from given range. Remove unnecessary code > > resulting from this. > > > > Signed-off-by: Jan Kara > > --- > > mm/filemap.c | 9 ++------- > > 1 file changed, 2 insertions(+), 7 deletions(-) > > > > diff --git a/mm/filemap.c b/mm/filemap.c > > index fe20329c83cd..479fc54b7cd1 100644 > > --- a/mm/filemap.c > > +++ b/mm/filemap.c > > @@ -421,18 +421,13 @@ static void __filemap_fdatawait_range(struct address_space *mapping, > > > > pagevec_init(&pvec, 0); > > while ((index <= end) && > > - (nr_pages = pagevec_lookup_tag(&pvec, mapping, &index, > > - PAGECACHE_TAG_WRITEBACK, > > - min(end - index, (pgoff_t)PAGEVEC_SIZE-1) + 1)) != 0) { > > + (nr_pages = pagevec_lookup_range_tag(&pvec, mapping, > > + &index, end, PAGECACHE_TAG_WRITEBACK, PAGEVEC_SIZE))) { > > While touching this, can we clean this up by moving the lookup > outside the while condition? i.e: > > while (index <= end) { > unsigned i; > > nr_pages = pagevec_lookup_range_tag(&pvec, mapping, &index, > end, PAGECACHE_TAG_WRITEBACK, PAGEVEC_SIZE); > if (!nr_pages) > break; Yeah, that makes sense. I'll update it. Honza -- Jan Kara SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org