linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Jan Kara <jack@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: readahead: Increase maximum readahead window
Date: Thu, 5 Oct 2017 10:39:33 +0200	[thread overview]
Message-ID: <20171005083933.GB28132@quack2.suse.cz> (raw)
In-Reply-To: <20171004174151.GA6497@magnolia>

On Wed 04-10-17 10:41:51, Darrick J. Wong wrote:
> On Wed, Oct 04, 2017 at 11:12:05AM +0200, Jan Kara wrote:
> > Increase default maximum allowed readahead window from 128 KB to 512 KB.
> > This improves performance for some workloads (see below for details) where
> > ability to scale readahead window to larger sizes allows for better total
> > throughput while chances for regression are rather low given readahead
> > window size is dynamically computed based on observation (and thus it never
> > grows large for workloads with a random read pattern).
> > 
> > Note that the same tuning can be done using udev rules or by manually setting
> > the sysctl parameter however we believe the new value is a better default most
> > users will want to use. As a data point we carry this patch in SUSE kernels
> > for over 8 years.
> > 
> > Some data from the last evaluation of this patch (on 4.4-based kernel, I can
> > rerun those tests on a newer kernel but nothing has changed in the readahead
> > area since 4.4). The patch was evaluated on two machines
> 
> This is purely speculating, but I think this is worth at least a quick
> retry on 4.14 to see what's changed in the past 10 kernel release.  For
> one thing, ext3 no longer exists, and XFS' file IO path has changed
> quite a lot since then.

ext3 in this test is actually using ext4 driver already, so that has not
changed. I agree XFS has changed quite a bit so results might differ there.
I can rerun it with current kernel to see whether XFS behavior changed.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2017-10-05  8:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-04  9:12 [PATCH] mm: readahead: Increase maximum readahead window Jan Kara
2017-10-04 17:41 ` Darrick J. Wong
2017-10-05  8:39   ` Jan Kara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171005083933.GB28132@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=darrick.wong@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).