From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: Adam Borowski <kilobyte@angband.pl>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
Al Viro <viro@ZenIV.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfs: hard-ban creating files with control characters in the name
Date: Thu, 5 Oct 2017 14:47:03 +0100 [thread overview]
Message-ID: <20171005144703.16725c02@alans-desktop> (raw)
In-Reply-To: <20171003173215.axcwmd4ynmvgkyym@angband.pl>
> For malformed Unicode or such, it'd make sense, yeah.
Not really. It's legitimate to have bad unicode in a directory, or have a
file system where some users are still in 8bit Russian encoding and some
are unicode for example.
The fix for this has always been the same - don't use shell script and
similar things (php for example) where incorrect quoting causes you to
execute random attacker code.
As most of the waya to attack a shell script are printable symbols like
$, ; ` and * you aren't going to save anyone by adding hacks to the VFS.
Alan
prev parent reply other threads:[~2017-10-05 13:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 0:50 [PATCH] vfs: hard-ban creating files with control characters in the name Adam Borowski
2017-10-03 2:07 ` Al Viro
2017-10-03 3:22 ` Adam Borowski
2017-10-05 10:07 ` Olivier Galibert
2017-10-06 14:54 ` Matthew Wilcox
2017-10-03 16:40 ` Theodore Ts'o
2017-10-03 17:32 ` Adam Borowski
2017-10-03 18:58 ` Theodore Ts'o
2017-10-03 19:12 ` Casey Schaufler
2017-10-05 16:16 ` J. Bruce Fields
2017-10-06 2:09 ` Dave Chinner
2017-10-06 14:38 ` J. Bruce Fields
2017-10-06 14:57 ` Matthew Wilcox
2017-10-06 20:00 ` Theodore Ts'o
2017-10-08 22:03 ` Dave Chinner
2017-10-05 13:47 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005144703.16725c02@alans-desktop \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=kilobyte@angband.pl \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).