Re: [PATCH] hfsplus: return ENODATA when no xattr is found

["Ernesto A. Fernández" <ernesto.mnd.fernandez@gmail.com>]

On Thu, Oct 19, 2017 at 05:15:13PM -0700, Viacheslav Dubeyko wrote:
> On Thu, 2017-10-19 at 20:02 -0300, Ernesto A. Fernández wrote:
> > On Thu, Oct 19, 2017 at 08:30:53PM +0000, Hin-Tak Leung wrote:
> > > 
> > > 
> > > --------------------------------------------
> > > On Thu, 19/10/17, Ernesto A. Fernández <ernesto.mnd.fernandez@gmail
> > > .com> wrote:
> > > 
> > > > 
> > > > There are several points in the code where ENOENT or
> > > > EOPNOTSUPP are
> > > > used to signal that an extended attribute does not exist.
> > > > This is
> > > > clearly noticeable from the odd error messages shown by
> > > > setfattr and
> > > > getfattr. Use ENODATA instead.
> > >  
> > > > 
> > > > Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.
> > > > com>
> > > Nacked.
> > > 
> > > I think you perhaps mis-understood the code. Some (older) HFS+ file
> > > system does not have attribute records so it gives  EOPNOTSUPP . It
> > > is not NODATA, but that you cannot write attribute data(or read) to
> > > such old fs. Likewise, the other changes from ENOENT to ENODATA
> > > seems wrong too. "Not found" is not "no data" ( = "found but
> > > null").
> > > 
> > If you create a fresh hfsplus filesystem and run:
> > 
> > touch test
> > setfattr -x user.1 test
> > 
> > you will get an "operation not supported" error. That isn't right.
> > Now
> > if you run:
> > 
> > setfattr -n user.1 test
> > setfattr -x user.1 test
> > setfattr -x user.1 test
> > 
> > you will get a "no such file or directory" error. Also bad, the file
> > is
> > right there. This one is caused by the ENOENT.
> 
> 
> You suggested to exclude all this code (xattr support) from the HFS+
> file system driver. What is the point to review your patches for the
> code that will be deleted? If this code will be deleted then no
> troubles anymore. Forget and relax.

I never suggested anything like that. I'm guessing your confusion is
because of the patch I sent to drop ACL support, but I never spoke of
xattrs.

And you seem to believe it was my idea, but it wasn't. I only wrote
the patch because I was the one who first noticed it was broken a
couple of months ago.

Ernest

> 
> Regards,
> Vyacheslav Dubeyko.
> 
>