From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:34684 "EHLO
        ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751259AbdJXCQi (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Mon, 23 Oct 2017 22:16:38 -0400
Date: Tue, 24 Oct 2017 03:16:36 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Greg Edwards <gedwards@ddn.com>
Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: guard_bio_eod() needs to consider partitions
Message-ID: <20171024021636.GZ21978@ZenIV.linux.org.uk>
References: <20171024011007.24855-1-gedwards@ddn.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171024011007.24855-1-gedwards@ddn.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, Oct 23, 2017 at 07:10:07PM -0600, Greg Edwards wrote:
> guard_bio_eod() needs to look at the partition capacity, not just the
> capacity of the whole device, when determining if truncation is
> necessary.
> 
> [   60.268688] attempt to access beyond end of device
> [   60.268690] unknown-block(9,1): rw=0, want=67103509, limit=67103506
> [   60.268693] buffer_io_error: 2 callbacks suppressed
> [   60.268696] Buffer I/O error on dev md1p7, logical block 4524305, async page read
> 
> Fixes: 74d46992e0d9 ("block: replace bi_bdev with a gendisk pointer and partitions index")
> Signed-off-by: Greg Edwards <gedwards@ddn.com>

That smells like a nasty source of overhead, especially on SMP boxen...