From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:35083 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbdJXHqR (ORCPT ); Tue, 24 Oct 2017 03:46:17 -0400 Date: Tue, 24 Oct 2017 09:46:15 +0200 From: Christoph Hellwig To: Al Viro Cc: Greg Edwards , linux-fsdevel@vger.kernel.org, Christoph Hellwig , linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs: guard_bio_eod() needs to consider partitions Message-ID: <20171024074615.GA14396@lst.de> References: <20171024011007.24855-1-gedwards@ddn.com> <20171024021636.GZ21978@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171024021636.GZ21978@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Oct 24, 2017 at 03:16:36AM +0100, Al Viro wrote: > > Fixes: 74d46992e0d9 ("block: replace bi_bdev with a gendisk pointer and partitions index") > > Signed-off-by: Greg Edwards > > That smells like a nasty source of overhead, especially on SMP boxen... We could just use __disk_get_part similar to the partition remapping, or just pass the block_device to guard_bio_eod.