From: Greg Edwards <gedwards@ddn.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs: guard_bio_eod() needs to consider partitions
Date: Tue, 24 Oct 2017 09:26:59 -0600 [thread overview]
Message-ID: <20171024152658.GA1477@psuche> (raw)
In-Reply-To: <20171024074615.GA14396@lst.de>
On Tue, Oct 24, 2017 at 09:46:15AM +0200, Christoph Hellwig wrote:
> On Tue, Oct 24, 2017 at 03:16:36AM +0100, Al Viro wrote:
>>> Fixes: 74d46992e0d9 ("block: replace bi_bdev with a gendisk pointer and partitions index")
>>> Signed-off-by: Greg Edwards <gedwards@ddn.com>
>>
>> That smells like a nasty source of overhead, especially on SMP boxen...
>
> We could just use __disk_get_part similar to the partition remapping,
> or just pass the block_device to guard_bio_eod.
Do you have a preference? __disk_get_part would be isolated to
guard_bio_eod. If we pass in the block_device, it would also touch all
the mpage_bio_submit callers.
next prev parent reply other threads:[~2017-10-24 15:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 1:10 [PATCH] fs: guard_bio_eod() needs to consider partitions Greg Edwards
2017-10-24 2:16 ` Al Viro
2017-10-24 7:46 ` Christoph Hellwig
2017-10-24 15:26 ` Greg Edwards [this message]
2017-10-24 17:21 ` [PATCH v2] " Greg Edwards
2017-11-01 17:49 ` Greg Edwards
2017-11-10 8:46 ` Christoph Hellwig
2017-11-10 15:25 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024152658.GA1477@psuche \
--to=gedwards@ddn.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).