From: Greg Edwards <gedwards@ddn.com>
To: <linux-fsdevel@vger.kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
"Jens Axboe" <axboe@kernel.dk>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] fs: guard_bio_eod() needs to consider partitions
Date: Wed, 1 Nov 2017 11:49:42 -0600 [thread overview]
Message-ID: <20171101174942.GJ21917@psuche> (raw)
In-Reply-To: <20171024172148.12397-1-gedwards@ddn.com>
On Tue, Oct 24, 2017 at 11:21:48AM -0600, Greg Edwards wrote:
> guard_bio_eod() needs to look at the partition capacity, not just the
> capacity of the whole device, when determining if truncation is
> necessary.
>
> [ 60.268688] attempt to access beyond end of device
> [ 60.268690] unknown-block(9,1): rw=0, want=67103509, limit=67103506
> [ 60.268693] buffer_io_error: 2 callbacks suppressed
> [ 60.268696] Buffer I/O error on dev md1p7, logical block 4524305, async page read
>
> Fixes: 74d46992e0d9 ("block: replace bi_bdev with a gendisk pointer and partitions index")
> Signed-off-by: Greg Edwards <gedwards@ddn.com>
> ---
> Changes from v1:
> * use __disk_get_part instead of disk_get_part, similar to what
> blk_partition_remap does
Al, Christoph,
Any thoughts on this version?
It would be nice to get this fixed before 4.14 goes out, as this is a
regression from previous releases.
Greg
next prev parent reply other threads:[~2017-11-01 17:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 1:10 [PATCH] fs: guard_bio_eod() needs to consider partitions Greg Edwards
2017-10-24 2:16 ` Al Viro
2017-10-24 7:46 ` Christoph Hellwig
2017-10-24 15:26 ` Greg Edwards
2017-10-24 17:21 ` [PATCH v2] " Greg Edwards
2017-11-01 17:49 ` Greg Edwards [this message]
2017-11-10 8:46 ` Christoph Hellwig
2017-11-10 15:25 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101174942.GJ21917@psuche \
--to=gedwards@ddn.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).