From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from legacy.ddn.com ([64.47.133.206]:32433 "EHLO legacy.ddn.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751324AbdKARtq (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Wed, 1 Nov 2017 13:49:46 -0400
Date: Wed, 1 Nov 2017 11:49:42 -0600
From: Greg Edwards <gedwards@ddn.com>
To: <linux-fsdevel@vger.kernel.org>
CC: Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
        "Jens Axboe" <axboe@kernel.dk>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] fs: guard_bio_eod() needs to consider partitions
Message-ID: <20171101174942.GJ21917@psuche>
References: <20171024011007.24855-1-gedwards@ddn.com>
 <20171024172148.12397-1-gedwards@ddn.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20171024172148.12397-1-gedwards@ddn.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Oct 24, 2017 at 11:21:48AM -0600, Greg Edwards wrote:
> guard_bio_eod() needs to look at the partition capacity, not just the
> capacity of the whole device, when determining if truncation is
> necessary.
>
> [   60.268688] attempt to access beyond end of device
> [   60.268690] unknown-block(9,1): rw=0, want=67103509, limit=67103506
> [   60.268693] buffer_io_error: 2 callbacks suppressed
> [   60.268696] Buffer I/O error on dev md1p7, logical block 4524305, async page read
>
> Fixes: 74d46992e0d9 ("block: replace bi_bdev with a gendisk pointer and partitions index")
> Signed-off-by: Greg Edwards <gedwards@ddn.com>
> ---
> Changes from v1:
>   * use __disk_get_part instead of disk_get_part, similar to what
>     blk_partition_remap does

Al, Christoph,

Any thoughts on this version?

It would be nice to get this fixed before 4.14 goes out, as this is a
regression from previous releases.

Greg