From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 10 Nov 2017 10:08:18 +0100 From: Christoph Hellwig To: Dan Williams Cc: linux-nvdimm@lists.01.org, Jan Kara , Matthew Wilcox , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, Jeff Moyer , Ross Zwisler , linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, hch@lst.de Subject: Re: [PATCH 14/15] dax: associate mappings with inodes, and warn if dma collides with truncate Message-ID: <20171110090818.GE4895@lst.de> References: <150949209290.24061.6283157778959640151.stgit@dwillia2-desk3.amr.corp.intel.com> <150949217152.24061.9869502311102659784.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <150949217152.24061.9869502311102659784.stgit@dwillia2-desk3.amr.corp.intel.com> Sender: owner-linux-mm@kvack.org List-ID: > + struct { > + /* > + * ZONE_DEVICE pages are never on an lru or handled by > + * a slab allocator, this points to the hosting device > + * page map. > + */ > + struct dev_pagemap *pgmap; > + /* > + * inode association for MEMORY_DEVICE_FS_DAX page-idle > + * callbacks. Note that we don't use ->mapping since > + * that has hard coded page-cache assumptions in > + * several paths. > + */ What assumptions? I'd much rather fix those up than having two fields that have the same functionality. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org